[#40081] - Fix undefined key in HTMLDocument setBuffer
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.2-dev
- # 40081
- Diff
- Fedik:fix-doc-setbuff
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fix undefined key in HTMLDocument setBuffer
Testing Instructions
Apply patch.
Enable error reaporting.
Add to index.php of any template:
$this->setBuffer('<h1>FooBar</h1>', ['type' => 'component']);Navigate to any page with this template.
Actual result BEFORE applying this Pull Request
Warning message: accesing undefinend key.
Expected result AFTER applying this Pull Request
No warning, the page render "Foobar" heading.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Yes, that is expected, because the test instruction overrides whole component output, and every srcipt will be broken.
But that only for testing setBuffer method, so all good
I have tested this item
Tested successfully in Joomla 4.3.10-dev of 16 March in PHP 8.1.10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40081.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40081.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40081.
This pull request has been automatically rebased to 4.3-dev.
| Labels |
Added:
?
bug
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 19:57:09 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
PR-4.3-dev
|
||
No warnings however in the browser's console.