[#40077] - [4.3][Guided Tours] target corrections
- Fixed in Code Base
- 11 Mar 2023
- Medium
- Build: 4.3-dev
- # 40077
- Diff
- obuisard:guided-tours-target
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issues #40006 and #40029.
Summary of Changes
The script considers all steps with a target as interactive.
This was incorrect.
While fixing this issue, it appeared that many steps were not having the right type.
This PR also removes the :has selector to improve compatibility with Firefox.
Testing Instructions
Start the 'Create a contact' tour.
Step through the tour, up to the 'Enter detailed information'.
Actual result BEFORE applying this Pull Request
You cannot tab through the back/next/cancel buttons, only shift tab.
Expected result AFTER applying this Pull Request
You can tab through the back/next/cancel buttons.
Note: this PR fixes steps that were set with a wrong type. Now that steps are correct, you will encounter steps with 'Next' being disabled on required AND NOT required input fields. This is temporary and addressed in PR #40062.
It's a chicken and egg thing here...
Under Firefox, category and tags should be properly targeted with this PR as well, once resuming the tour.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql JavaScript Repository NPM Change Installation |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
| Title |
|
||||||
Successful in principle, but: Field: Enter an alias: the button Next is inactive for automatic insertion of the alias.
Took the NPM Package
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40077.
@ChristineWk see the note in the PR description, it was expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40077.
I have tested this item
@obuisard
Ah, I see now the "chicken and egg thing" :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40077.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40077.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-11 23:24:37 |
| Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on 2575189
Installed the pre-built full zip tile. Went through step by step of the PR instructions.
I was able to tab from cancel to back to next with no issues. Shift-tab still worked to go the opposite direction as well.
Test Successful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40077.