Feeling Lucky
?
NPM Resource Changed
PR-4.4-dev
[#40076] - Lints the cypress system tests
- Fixed in Code Base
- 11 Mar 2023
- Medium
- Build: 4.4-dev
- # 40076
- Diff
- Digital-Peak:lint/tests
User tests: Successful: Unsuccessful:
Adds he cypress specs to the linter for testing. The override is needed in the config file, so all the functions and the global "cy" variable are not reported as undefined.
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
NPM Resource Changed
PR-4.4-dev
|
||
dgrammatiko
- comment
- 10 Mar 2023
LGTM
FWIW if you want to be way more strict what could be done is:
- in the package.json split the lint script so that it could check the build and tests folders independently, with different configurations.
- copy the existing config and add the https://www.npmjs.com/package/eslint-plugin-chai-friendly and https://www.npmjs.com/package/eslint-plugin-cypress
laoneo
- comment
- 11 Mar 2023
For now I would leave it as it is, without adding another dev dependency. We can do that later when we have the need for it.
MacJoom
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-11 15:29:51 |
| Closed_By | ⇒ | MacJoom |
@dgrammatiko can yo have a look here if did not miss anything?