[#40048] - In com_tags, a tagged element's text-variable is transformed into nul…
- Fixed in Code Base
- 10 Mar 2023
- Medium
- Build: 4.3-dev
- # 40048
- Diff
- svenbluege:fix_php_81_deprecated_messages_J43
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Deprecation messages are shown for some tagged elements:
Summary of Changes
In com_tags, a tagged element's text-variable is transformed into null if the value is empty.
That causes deprecation messages in plugins like loadmodules and emailcloak. They usually don't need to check for null values in $article->text.
Testing Instructions
- configure PHP to show deprecation messages
- create a new contact using com_contact: just enter a name and tag it with "testtag"
- open the frontend /index.php?option=com_tags&view=tags
- click on the new tag 'testtag'.
- see the deprecation messages.
Actual result BEFORE applying this Pull Request
Following the test instructions, deprecation messages are shown
Expected result AFTER applying this Pull Request
Following the test instructions, deprecation messages are now shown
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40048.
| Labels |
Added:
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-10 03:32:58 |
| Closed_By | ⇒ | obuisard |
Thank you Sven @svenbluege for the PR!
This issue was fixed with the same code in 4.2.7, I'm missing the change in 4.3. Here is my try to add it to 4.3 again.
Original PR which was included in 4.2.7: #39640