Joomla! Issue Tracker | Joomla! CMS #40049

No Code Attached Yet

Closed
8 Mar 2023
Medium
Build: 4.2-dev
# 40049

brianteeman
8 Mar 2023

Steps to reproduce the issue

install Joomla in a subdirectory
set codemirror as the default editor
in the codemirror plugin set the kepmap to vim
create a new article

Expected result

textarea using codemirror

Actual result

codemirror fails to load as it cant find the path to the keymap

Additional comments

The problem appears to lie in the js as this code

    if (this.options.keyMapUrl) {
      await import(`${this.host}/${this.options.keyMapUrl}`);
    }

results in
"keyMapUrl":"media\/vendor\/codemirror\/keymap\/vim.min.js"}

instead of
"keyMapUrl":"MYFOLDER\/media\/vendor\/codemirror\/keymap\/vim.min.js"}

@dgrammatiko looks like it might be the same error we have had before but the js makes no sense to me so sorry I cant fix it

brianteeman - open - 8 Mar 2023

joomla-cms-bot - change - 8 Mar 2023

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 8 Mar 2023

dgrammatiko - comment - 8 Mar 2023

So:

in the layout we have

joomla-cms/plugins/editors/codemirror/layouts/editors/codemirror/element.php

Lines 37 to 38 in e462044

    
           $editor          = 'editor="' . ltrim(HTMLHelper::_('script', $basePath . 'lib/codemirror' . $extJS, ['version' => 'auto', 'pathOnly' => true]), '/') . '?' . $mediaVersion . '"'; 
        
           $addons          = 'addons="' . ltrim(HTMLHelper::_('script', $basePath . 'lib/addons' . $extJS, ['version' => 'auto', 'pathOnly' => true]), '/') . '?' . $mediaVersion . '"';

that loads the relative js files

The $basePath and $modePath in the layout are passed from

joomla-cms/plugins/editors/codemirror/codemirror.php

Lines 261 to 262 in e462044

'basePath' => $this->basePath,

'modePath' => $this->modePath,

which are defined here

joomla-cms/plugins/editors/codemirror/codemirror.php

Lines 51 to 60 in e462044

    
               protected $basePath = 'media/vendor/codemirror/'; 
        
               /** 
        
                * Base path for editor modes. 
        
                * 
        
                * @var  string 
        
                * 
        
                * @since  4.0.0 
        
                */ 
        
               protected $modePath = 'media/vendor/codemirror/mode/%N/%N';

So it's obvious that those paths need the Uri::root() at the start

dgrammatiko - comment - 8 Mar 2023

#40051

Quy - change - 8 Mar 2023

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2023-03-08 16:30:31
Closed_By		⇒	Quy

Quy - close - 8 Mar 2023

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#40049] - [4.2] Codemirror keymaps

Steps to reproduce the issue

Expected result

Actual result

Additional comments

Add a Comment

	$editor = 'editor="' . ltrim(HTMLHelper::_('script', $basePath . 'lib/codemirror' . $extJS, ['version' => 'auto', 'pathOnly' => true]), '/') . '?' . $mediaVersion . '"';
	$addons = 'addons="' . ltrim(HTMLHelper::_('script', $basePath . 'lib/addons' . $extJS, ['version' => 'auto', 'pathOnly' => true]), '/') . '?' . $mediaVersion . '"';

	'basePath' => $this->basePath,
	'modePath' => $this->modePath,

	protected $basePath = 'media/vendor/codemirror/';

	/**
	* Base path for editor modes.
	*
	* @var string
	*
	* @since 4.0.0
	*/
	protected $modePath = 'media/vendor/codemirror/mode/%N/%N';