[#40017] - [4.3] Allow module Helper optional
- Fixed in Code Base
- 10 Mar 2023
- Medium
- Build: 4.3-dev
- # 40017
- Diff
- joomdonation:allow_module_helper_factory_optional
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Currently, a module uses service provider (our new modern module structure) requires registering HelperFactory service provider. However, not all modules require Helper class to get required data, so module HelperFactory should be optional.
Testing Instructions
- Use Joomla 4.3 nightly build
- Install this updated version mod_custom.zip of mod_custom module (it's the result of this PR #39931 , rebuild the module with our new module structure)
- Create an instance of Custom HTML module. Assign it to certain pages on your site (or just All Pages)
- Delete the file administrator/cache/autoload_psr4.php
Actual result BEFORE applying this Pull Request
You got fatal error: Resource 'Joomla\CMS\Helper\HelperFactoryInterface' has not been registered with the container
Expected result AFTER applying this Pull Request
No error. The module is being displayed properly
Link to documentations
Please select:
-
[] Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
[] Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Not on the computer right now. Does this work when a module is overwriting the constructor and still has the ild signature? If that works then it is fine.
Does this work when a module is overwriting the constructor and still has the ild signature
I don't really know how to do that because there are no modules like that in core test the behavior. I would say that it should work well because what I really do here is make the parameter nullable.
But to be safe, would be great if you could look at this when you are on your computer. Thanks.
I have tested this item
Tested successfully in Joomla 4.3.0-beta4-dev of 7 March using PHP 8.1.10
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40017.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40017.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40017.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-10 04:51:42 |
| Closed_By | ⇒ | obuisard |
Thank you again Tuan @joomdonation :-)
Joomla 4.2 already contains modules with the module structure.
I have built a module for Joomla 4.2 according to the new structure. It doesn't work now, fatal error.
Is it possible, without too much trouble, to merge this PR into the Joomla 4.2 branch as well? Or still wait until Joomal 4.3 comes out?
4.2.9 is the last 4.2 release, so you will have to wait for 4.3.0 to have this issue fixed.
Thanks Tuan.
Ping @laoneo for taking a look at this change.