Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40018] - [4.4] Use HelperFactory to get Helper for mod_quickicon

? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
5 Mar 2023

Pull Request for Issue # .

Summary of Changes

This PR makes small changes to mod_quickicon code to use HelperFactory to get it's Helper class. It has two benefits:

  1. Consistent code with how we are getting Helper for other modules. For example https://github.com/joomla/joomla-cms/blob/4.2-dev/modules/mod_articles_latest/src/Dispatcher/Dispatcher.php#L41
  2. Save the system from having to go to bootModule routine again before it can get module helper class.

Testing Instructions

  1. Use Joomla 4.3 nightly build
  2. Apply patch
  3. Access to administrator area of your site, look at Home Dashboard, Notifications section. Make sure the icons there are still being displayed (see the attached screenshot)

quick_icons

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2023
Category ⇒ Modules Administration
avatar joomdonation joomdonation - open - 5 Mar 2023
avatar joomdonation joomdonation - change - 5 Mar 2023
Status New ⇒ Pending
avatar carlitorweb carlitorweb - test_item - 11 Mar 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 11 Mar 2023

I have tested this item ✅ successfully on 632ec44

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40018.

avatar chmst chmst - test_item - 12 Mar 2023 - Tested successfully
avatar chmst
chmst - comment - 12 Mar 2023

I have tested this item ✅ successfully on 632ec44

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40018.

avatar chmst chmst - change - 12 Mar 2023
Status Pending ⇒ Ready to Commit
avatar chmst
chmst - comment - 12 Mar 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40018.

avatar Quy Quy - change - 12 Mar 2023
Labels Added: ? PR-4.3-dev
avatar laoneo laoneo - change - 2 May 2023
Title
…
[4.3] Use HelperFactory to get Helper for mod_quickicon
[4.4] Use HelperFactory to get Helper for mod_quickicon
avatar laoneo laoneo - edited - 2 May 2023
avatar laoneo laoneo - change - 2 May 2023
Labels Added: bug PR-4.4-dev
Removed: PR-4.3-dev
avatar laoneo laoneo - change - 5 May 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-05-05 12:42:42
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 5 May 2023
avatar laoneo laoneo - merge - 5 May 2023
avatar laoneo
laoneo - comment - 5 May 2023

Thanks!

Add a Comment

Login with GitHub to post a comment