User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This PR makes some minor clean up to Step model from guided tours component :
canEditState
method. We do not have to set tour_id for the record before checking the permission. The only case we have to do that is when adding a new step, but this is already being taken care by getItem
methodsave
method. We do not have get tour_id from session and set it for step. The value for that field is already passed from hidden variable on step form (and we already validate and make sure it's available when a step is being added/editted)Works
Works with cleaner code
Please select:
[] Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
[] Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-4.3-dev
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-09 20:51:31 |
Closed_By | ⇒ | obuisard |
Thank you Tuan @joomdonation, appreciated!
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40016.