Feeling Lucky
?
PR-4.3-dev
[#40015] - [4.3][GUIDEDTOURS] Move code from helper to model
- Fixed in Code Base
- 10 Mar 2023
- Medium
- Build: 4.3-dev
- # 40015
- Diff
- joomdonation:move_code_from_helper_to_model
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR move the code which is used to update language of steps belong to a tour from Helper to Model for two reasons:
- In model, we have database object and ready to use, unless in Helper, we have to use Factory::getDbo() to get database object (we are trying to move a way from using the static methods from Factory)
- I believe that a doing something operation, especially update data from database should be a task of model, not something for Helper
Testing Instructions
- Use Joomla 4.3 nightly build or a Joomla 4.3 installation which has Guided Tours available
- Edit a tour, save it, make sure nothing broken
Actual result BEFORE applying this Pull Request
Works.
Expected result AFTER applying this Pull Request
Works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
khu5h1
- comment
- 9 Mar 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40015.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 9 Mar 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40015.
obuisard
- comment
- 9 Mar 2023
Not sure why there is conflict here. Can you check Tuan @joomdonation ? Thanks!
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-10 04:29:20 |
| Closed_By | ⇒ | obuisard |
obuisard
- comment
- 10 Mar 2023
Thank you Tuan @joomdonation !
joomdonation
- comment
- 10 Mar 2023
Thanks Olivier !
I have tested this item✅ successfully on 7da4654
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40015.