[#40003] - [4.3][Guided Tours] Cleanup Tours model
- Fixed in Code Base
- 9 Mar 2023
- Medium
- Build: 4.3-dev
- # 40003
- Diff
- joomdonation:guidertours_cleanup_tours_model
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes several clean up to Tours module from Guided Tours extension
- No need to override
getEmptyStateQuerymethod from parent class (This override contains really wrong code, seems copied from Steps model) - Remove getTable method. We do not need this method from a List model
Testing Instructions
- Install Joomla from download package generated by this PR (to make sure Guided Tours is available on your installation). Access to Guided Tours, see list of tours and make sure nothing is broken from this page
Actual result BEFORE applying this Pull Request
Unnecessary wrong code in Tours model
Expected result AFTER applying this Pull Request
The unnecessary wrong code removed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration |
| Status | New | ⇒ | Pending |
Question for @obuisard : In this model, we also have code to handle extensions filter (no idea how it should work). However, that filter is not in filter form, so should we remove that code as well ?
No, it is used by the Guided Tours module to show tours according to a specific extension that is showing on the screen.
No, it is used by the Guided Tours module to show tours according to a specific extension that is showing on the screen
Ah, OK. Thanks for the info.
| Labels |
Added:
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40003.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40003.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40003.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-09 19:53:05 |
| Closed_By | ⇒ | obuisard |
Thank you Tuan @joomdonation!
Question for @obuisard : In this model, we also have code to handle extensions filter (no idea how it should work). However, that filter is not in filter form, so should we remove that code as well ?