? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
4 Mar 2023

Pull Request for Issue # .

Summary of Changes

This PR makes several clean up to Steps model:

  • Remove getTable method. It is not used for a List model
  • Do not need to set filter.search and filter.published states, it is handled by parent class.
  • Correct getStoreId method, it needs to contains filter.tour_id state value
  • Rename variable from $tour_id to $tourId to follow camel case naming convension

Testing Instructions

  1. Install Joomla base on download package generated by this PR to make sure you have guided tours available in the installation. Or if you have a site with guide tours already, apply this PR
  2. Access to Guided Tours, then view steps of a tour and make sure nothing is broken on that screen.

Actual result BEFORE applying this Pull Request

Contains unnecessary code

Expected result AFTER applying this Pull Request

Unnecessary code removed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2023
Category Administration
avatar joomdonation joomdonation - open - 4 Mar 2023
avatar joomdonation joomdonation - change - 4 Mar 2023
Status New Pending
avatar chmst chmst - test_item - 4 Mar 2023 - Tested successfully
avatar chmst
chmst - comment - 4 Mar 2023

I have tested this item successfully on d930866


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40004.

avatar Quy Quy - test_item - 8 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 8 Mar 2023

I have tested this item successfully on d930866


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40004.

avatar Quy Quy - change - 8 Mar 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 8 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40004.

avatar obuisard obuisard - change - 8 Mar 2023
Labels Added: ?
avatar obuisard obuisard - change - 8 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-08 03:54:29
Closed_By obuisard
avatar obuisard obuisard - close - 8 Mar 2023
avatar obuisard obuisard - merge - 8 Mar 2023
avatar obuisard
obuisard - comment - 8 Mar 2023

Thank you Tuan @joomdonation for the code review.

Add a Comment

Login with GitHub to post a comment