? NPM Resource Changed bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
4 Mar 2023

Pull Request for Issue # .

Summary of Changes

Testing Instructions

  • Run npm i
  • run npm watch:com_media
  • Open the admin site and go to media manager
  • Open the browser console and refresh
  • Observe the warnings
  • Apply the PR
  • run npm watch:com_media
  • Open the admin site and go to media manager
  • Open the browser console and refresh
  • No warnings
  • Check that uploading, editing, etc works as before

Actual result BEFORE applying this Pull Request

Screenshot 2023-03-04 at 14 05 04

Screenshot 2023-03-04 at 14 05 14

Expected result AFTER applying this Pull Request

No warnings

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2023
Category JavaScript Administration com_media NPM Change
avatar dgrammatiko dgrammatiko - open - 4 Mar 2023
avatar dgrammatiko dgrammatiko - change - 4 Mar 2023
Status New Pending
c855d0c 4 Mar 2023 avatar dgrammatiko cs
avatar dgrammatiko dgrammatiko - change - 4 Mar 2023
Labels Added: NPM Resource Changed PR-4.3-dev
1a16ed2 4 Mar 2023 avatar dgrammatiko oops
avatar Quy Quy - test_item - 6 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 6 Mar 2023

I have tested this item successfully on 25990fe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40002.

avatar viocassel viocassel - test_item - 12 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 12 Mar 2023

I have tested this item successfully on 25990fe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40002.

avatar Quy Quy - change - 12 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40002.

avatar obuisard obuisard - change - 4 May 2023
Labels Added: ? bug
avatar obuisard obuisard - close - 4 May 2023
avatar obuisard obuisard - merge - 4 May 2023
avatar obuisard obuisard - change - 4 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-04 17:11:55
Closed_By obuisard
avatar obuisard
obuisard - comment - 4 May 2023

Thanks Dimitris @dgrammatiko for the PR :-)

Add a Comment

Login with GitHub to post a comment