[#39984] - [4.3] Phan: Optimizing import statements
- Fixed in Code Base
- 8 Mar 2023
- Medium
- Build: 4.3-dev
- # 39984
- Diff
- Hackwar:4.3-imports
User tests: Successful: Unsuccessful:
Summary of Changes
I ran the "optimize imports" action from PHPStorm on our codebase and this is what was the result. (Minus some unnecessary optimizations, like removing spaces in JS or ordering lowercase imports before uppercase ones.)
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_fields com_installer com_joomlaupdate com_messages com_templates Repository Front End com_tags Installation Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
Looks like a lot of those things are from earlier refactoring, where for example all Factory::getDbo() were moved to a $this->getDatabase() instead of something like that.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39984.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39984.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39984.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-08 05:12:04 |
| Closed_By | ⇒ | obuisard |
I ran a similar check yesterday in vs-code with similar results. The difference was that I just assumed in my ignorance that as there were so many that they must have been false positives.