Feeling Lucky
?
PR-4.3-dev
[#39983] - [4.3] Phan: Languagefilter plugin
- Fixed in Code Base
- 12 Mar 2023
- Medium
- Build: 4.3-dev
- # 39983
- Diff
- Hackwar:4.3-languagefilter
User tests: Successful: Unsuccessful:
Summary of Changes
These changes resulted from a static analysis run of phan. These are the changes:
- The use statement is not used in the code anywhere
- parseRule() returns null, not an array. The return statement and the $array can be removed.
- onUserAfterSave() actually returns null and not boolean.
- The way we are setting the cookie has been deprecated and this is now the new version how to call that.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Title |
|
||||||
chmst
- comment
- 12 Mar 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39983.
| Status | Pending | ⇒ | Ready to Commit |
chmst
- comment
- 12 Mar 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39983.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-12 15:11:12 |
| Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on d089a96
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39983.