PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
2 Mar 2023

Summary of Changes

This is another block of changes from static code analysis with phan. Changed default values are due to false values. When an attribute is only used as boolean, it should not be declared as object and if it is exclusively used as string/object, it isn't an array.

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2023
Category Libraries
avatar Hackwar Hackwar - open - 2 Mar 2023
avatar Hackwar Hackwar - change - 2 Mar 2023
Status New Pending
avatar Hackwar Hackwar - change - 2 Mar 2023
Labels Added: PR-4.3-dev
avatar Hackwar Hackwar - change - 2 Mar 2023
Title
[4.3] Optimisations from static analysis to MVC classes
[4.3] Phan: MVC classes
avatar Hackwar Hackwar - edited - 2 Mar 2023
avatar Hackwar Hackwar - change - 4 Apr 2023
Title
[4.3] Phan: MVC classes
[4.4] Phan: MVC classes
avatar Hackwar Hackwar - edited - 4 Apr 2023
avatar Hackwar Hackwar - change - 4 Apr 2023
Labels Added: PR-4.4-dev
avatar Hackwar Hackwar - change - 4 Apr 2023
Labels Added: ?
Removed: PR-4.3-dev
avatar Fedik Fedik - test_item - 4 Apr 2023 - Tested successfully
avatar Fedik
Fedik - comment - 4 Apr 2023

I have tested this item successfully on a9a3a80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39985.

avatar laoneo laoneo - change - 4 Apr 2023
Labels Removed: ?
avatar laoneo laoneo - close - 5 Apr 2023
avatar laoneo laoneo - merge - 5 Apr 2023
avatar laoneo laoneo - change - 5 Apr 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-05 08:05:03
Closed_By laoneo
avatar laoneo
laoneo - comment - 5 Apr 2023

Thanks!

Add a Comment

Login with GitHub to post a comment