Feature ? Documentation Required PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Feb 2023

pr for #38881

On a complex site with a lot of categories it can be very difficult to sort the categories using drag and drop because you cannot get the relevant tree on the same page.

This adds a new filter to com_category that allows you to select the parent category. It's particularly useful when used with the max levels filter.

Testing is easiest if you have the test sample data installed as that has a lot of categories

This is a remake of 27486 to support all components that use categories

Example with no filter

image

Example with category filter

image

Example with category and level filter

image

Example with TWO category filters and level filter

image

avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2023
Category Administration com_categories
avatar brianteeman brianteeman - open - 26 Feb 2023
avatar brianteeman brianteeman - change - 26 Feb 2023
Status New Pending
avatar richard67
richard67 - comment - 26 Feb 2023

@brianteeman If I understand right, this PR solves issue #38881 . Could you mention that issue at the top of the description as we usually do?

avatar richard67
richard67 - comment - 26 Feb 2023

Hmm PHPCS reports syntax errors but I have seen that in another PR, too, so I think it’s not related to this PR but the 4.3-dev branch could be broken. I will ask other maintainers to check.

Update: False alarm, I got confused by the log.

avatar brianteeman brianteeman - change - 26 Feb 2023
The description was changed
avatar brianteeman brianteeman - edited - 26 Feb 2023
avatar brianteeman
brianteeman - comment - 26 Feb 2023

@richard67 updated with the pr number - sorry I had just copy pasted the description from the last time

avatar richard67
richard67 - comment - 26 Feb 2023

@brianteeman Could you check PHPCS? I think I got confused by the log and my previous comment about the branch being broken could be wrong.

avatar brianteeman brianteeman - change - 26 Feb 2023
Labels Added: PR-4.3-dev
9dd3ec8 26 Feb 2023 avatar brianteeman cs
avatar richard67
richard67 - comment - 26 Feb 2023

@brianteeman You could run ./libraries/vendor/bin/phpcbf --extensions=php -p --standard=ruleset.xml ./administrator/components/com_categories/src/Model/CategoriesModel.php to see what it suggests.

avatar ChristineWk ChristineWk - test_item - 27 Feb 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 27 Feb 2023

I have tested this item successfully on 6255a8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39950.

avatar viocassel viocassel - test_item - 27 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 27 Feb 2023

I have tested this item successfully on 6255a8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39950.

avatar richard67 richard67 - change - 27 Feb 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 27 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39950.

avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar brianteeman brianteeman - change - 8 May 2023
Title
[4.3] Filter by category - levels
[5.0] Filter by category - levels
avatar brianteeman brianteeman - edited - 8 May 2023
avatar HLeithner HLeithner - change - 15 Jun 2023
Labels Added: Feature ? Documentation Required PR-5.0-dev
Removed: PR-4.3-dev
avatar HLeithner HLeithner - change - 15 Jun 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-15 07:00:08
Closed_By HLeithner
avatar HLeithner HLeithner - close - 15 Jun 2023
avatar HLeithner HLeithner - merge - 15 Jun 2023
avatar HLeithner
HLeithner - comment - 15 Jun 2023

thanks

avatar brianteeman
brianteeman - comment - 15 Jun 2023

thanks

Add a Comment

Login with GitHub to post a comment