[#39949] - Making the encoding consistent- changing lowercase utf to uppercase
- Closed
- 26 Feb 2023
- Medium
- Build: 4.3-dev
- # 39949
- Diff
- charvimehradu:testing
User tests: Successful: Unsuccessful:
Pull Request for Issue #39927 .
Summary of Changes
Replacing lowecase utf with uppercase.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_ajax com_associations com_banners com_cache com_categories |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
Drone and appveyor are failing due to syntax errors in PHP file. So there is something wrong with this PR. Possibly the change in .editorconfig should be reverted. Am on mobile client only and can’t check deeper now.
Hello @charvimehradu ,
Thanks for this PR, it's a very good start, now we just have to fix this minor stuff to get it merge-ready.
You can find details of the minor changes that are needed here https://ci.joomla.org/joomla/joomla-cms/62238/1/8
@charvimehradu Please check also the review comments by @sandewt and @joomdonation and revert all changes which are not in XML files. Thanks in advance.
| Category | Administration com_admin com_ajax com_associations com_banners com_cache com_categories | ⇒ | Administration com_finder com_joomlaupdate com_menus Installation Layout Libraries NPM Change Unit Tests |
| Category | Administration com_finder com_joomlaupdate com_menus Installation Layout Libraries NPM Change Unit Tests | ⇒ | Administration com_admin com_ajax com_associations com_banners com_cache com_categories |
| Labels |
Added:
?
NPM Resource Changed
|
||
@charvimehradu Your commit to revert the changes (2nd last commit) had merge conflicts. They are marked with >>>> and ==== and <<<< in the files. You need to resolve these conflicts (just search for the mentioned patterns and you will find them. Let us know if you need help with that. Alkternatively, and maybe that would be easier for you, just make a new pull request and then close this one in favour of the new one. Thanks in advance, and thanks for your work so far.
| Category | Administration com_admin com_ajax com_associations com_banners com_cache com_categories | ⇒ | Unit Tests Repository Administration com_admin SQL |
| Labels |
Removed:
?
NPM Resource Changed
|
||
yes thankyou @richard67 I'll just create a new PR for this one and then close this.
Thankyou everyone for your feedback and suggestions on my pull request. I have addressed all the suggested changes, and have created a new pull request #39951 . I'm optimistic that this time it will pass all the checks. @sandewt @richard67 @bembelimen @brianteeman @joomdonation
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-26 14:25:12 |
| Closed_By | ⇒ | charvimehradu | |
| Labels |
Added:
?
|
||
Related to #26221