[#39951] - Making the encoding consistent- changing lowercase utf to uppercase
- Fixed in Code Base
- 27 Feb 2023
- Medium
- Build: 4.3-dev
- # 39951
- Diff
- charvimehradu:utfreplace
User tests: Successful: Unsuccessful:
Pull Request for Issue #39927 .
Summary of Changes
-
This PR also replaces the wrong Windows line endings (CR+LF) with correct Unix line endings (LF) in 2 xml files "administrator/modules/mod_loginsupport/mod_loginsupport.xml" and "installation/language/ru-RU/langmetadata.xml".
-
Replacing lowercase utf with uppercase in .xml files.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_ajax com_associations com_banners com_cache com_categories |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Build | 4.2-dev | ⇒ | 4.3-dev |
| Labels |
Added:
PR-4.3-dev
Removed: ? |
||
I have tested this item
I can confirm that this PR here catches all 584 cases which I can find on a clean 4.3-dev branch on Linux when doing a find ./ -type f -name "*\.xml" -exec grep -Hn "encoding=\"utf-8\"" {} \; | grep "xml version=" and counting them with a | wc -l.
I've reviewed all changes and and can confirm they are correct.
Additional changes shown on GitHub for 2 xml files "administrator/modules/mod_loginsupport/mod_loginsupport.xml" and "installation/language/ru-RU/langmetadata.xml" but where you can't see what was changed are due to wrong Windows line endings CR+LF being replaced with correct Unix line endings LF.
Finally, redundant spaces have been removed from the XML tag. Ok by review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39951.
I have not tested this item.
Sorry, the last commit was not ok. Review comment will follow.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39951.
I have tested this item
All ok.
I can confirm that this PR here catches all 584 cases which I can find on a clean 4.3-dev branch on Linux when doing a find ./ -type f -name "*\.xml" -exec grep -Hn "encoding=\"utf-8\"" {} \; | grep "xml version=" and counting them with a | wc -l.
I've reviewed all changes and and can confirm they are correct.
Additional changes shown on GitHub for 2 xml files "administrator/modules/mod_loginsupport/mod_loginsupport.xml" and "installation/language/ru-RU/langmetadata.xml" but where you can't see what was changed are due to wrong Windows line endings CR+LF being replaced with correct Unix line endings LF.
Finally, redundant spaces have been removed from the XML tag. Ok by review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39951.
I have tested this item
I did some search and confirm that UTF-8 (in upper case) is recommended/standard. I also reviewed the changes from all the files (two times) and it looks good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39951.
| Status | Pending | ⇒ | Ready to Commit |
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39951.
Thks all
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-27 01:16:52 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
|
||
Thank you Charvi @charvimehradu for the PR!
Happy to help!
Other than the small change which I mentioned, this look good to me. If you made the change, I will submit my test result.