? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
16 Feb 2023

Pull Request for Issue #39871 .

Summary of Changes

  • Remove the position: absolute

Testing Instructions

Follow the issue instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2023
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 16 Feb 2023
avatar dgrammatiko dgrammatiko - change - 16 Feb 2023
Status New Pending
avatar dgrammatiko dgrammatiko - change - 16 Feb 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

I have tested this item white_check_mark successfully on 7dcca2e

avatar N6REJ N6REJ - test_item - 17 Feb 2023 - Tested unsuccessfully
avatar N6REJ N6REJ - alter_testresult - 17 Feb 2023 - N6REJ: Tested successfully
avatar N6REJ
N6REJ - comment - 17 Feb 2023

retested with DL'd pr release
and it worked fine, so probably something wrong with patchtester
image

avatar N6REJ N6REJ - change - 17 Feb 2023
Status Pending Ready to Commit
avatar dgrammatiko
dgrammatiko - comment - 17 Feb 2023
avatar Kaushik1216 Kaushik1216 - test_item - 17 Feb 2023 - Tested successfully
avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

I have tested this item successfully on 7dcca2e

I have tested this item Successfuly: 7dcca2e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39873.

avatar laoneo
laoneo - comment - 17 Feb 2023

@N6REJ can you mark your test as successful?

avatar dgrammatiko
dgrammatiko - comment - 17 Feb 2023

@laoneo the issue tracker has 2 successful tests

avatar laoneo
laoneo - comment - 17 Feb 2023

Which one is the second test? I see only the ones from @Kaushik1216.

avatar dgrammatiko
dgrammatiko - comment - 17 Feb 2023

I think the issue tracker comment was deleted but the tracker has 2 entries
Screenshot 2023-02-17 at 17 29 35

avatar laoneo
laoneo - comment - 17 Feb 2023

I was thinking the same, but just to be sure it would be good when @N6REJ can do a second test so we are on the safe side.

avatar Quy
Quy - comment - 17 Feb 2023

39873

avatar obuisard obuisard - change - 17 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-17 16:54:53
Closed_By obuisard
Labels Added: ?
avatar obuisard obuisard - close - 17 Feb 2023
avatar obuisard obuisard - merge - 17 Feb 2023
avatar obuisard
obuisard - comment - 17 Feb 2023

Thank you Dimitris @dgrammatiko !

avatar N6REJ N6REJ - alter_testresult - 17 Feb 2023 - n6rej: Tested successfully
avatar N6REJ
N6REJ - comment - 17 Feb 2023

I did "alter test" and mark it successful and it says it did but its not changing here... I did the same thing yesterday

Add a Comment

Login with GitHub to post a comment