? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Kaushik1216
Kaushik1216
16 Feb 2023

Newfeature

Alternate pr for pr #39819

Summary of Changes
ADD a messge that will display when no result found on searching in media manager

Testing Instructions
Search in media manager

Actual result BEFORE applying this Pull Request
No message shown if no result match .

Expected result AFTER applying this Pull Request
A message will shown if result not match with search

avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2023
Category Administration com_media NPM Change
avatar Kaushik1216 Kaushik1216 - open - 16 Feb 2023
avatar Kaushik1216 Kaushik1216 - change - 16 Feb 2023
Status New Pending
avatar Kaushik1216 Kaushik1216 - change - 16 Feb 2023
The description was changed
avatar Kaushik1216 Kaushik1216 - edited - 16 Feb 2023
avatar Kaushik1216
Kaushik1216 - comment - 16 Feb 2023

@dgrammatiko please check why build it's falling Is it this from my side or what ?

avatar richard67
richard67 - comment - 16 Feb 2023

@Kaushik1216 Does this replace your other PR #39819 ? If yes, then please close the other one. There should be a button on GitHub at the bottom of that PR to close it.

avatar sandewt sandewt - test_item - 17 Feb 2023 - Tested unsuccessfully
avatar sandewt
sandewt - comment - 17 Feb 2023

I have tested this item ? unsuccessfully on 23e3326

See comment


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39872.

avatar sandewt
sandewt - comment - 17 Feb 2023

You are almost there ?

issue_39470

Match source code (markup)

<div class="alert alert-info"> 
     <span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span> 
     <?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?> 
 </div> 

[EDIT class="ms-2" should be replaced by class="visually-hidden" and so on]

avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

we can not write php inside vue file it showing error

This is working fine see below :

Please test it on local system and run npm ci in CLI to compile js

avatar sandewt
sandewt - comment - 17 Feb 2023

This is working fine see below :

Indeed, but....
The idea is that the source code should match, look like this. For example, use the F12 key in FireFox to view the code.

issue_39470-2

Also see: #39819 (comment)

avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2023
Category Administration com_media NPM Change Administration com_media NPM Change Front End Templates (site)
avatar Kaushik1216 Kaushik1216 - change - 17 Feb 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2023
Category Administration com_media NPM Change Front End Templates (site) Administration com_media NPM Change
avatar sandewt
sandewt - comment - 17 Feb 2023

I would expect here a closing tag? But see that it is not used in other places in this file.
Please your opinion @dgrammatiko

Line 39 -

Correct ?

<span
    class="icon-info-circle"
    aria-hidden="true"
/>

Or is this desired ?

<span
    class="icon-info-circle"
    aria-hidden="true"
>
</span>
avatar dgrammatiko
dgrammatiko - comment - 17 Feb 2023

I would expect here a closing tag? But see that it is not used in other places in this file.

This is a .vue file and there's a special way that HTML elements are treated (similar to React's JSX). This is fine and actually if you write it as

<span
    class="icon-info-circle"
    aria-hidden="true"
>
</span>

you will get a notice from the linter

avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

@dgrammatiko @sandewt please test now

avatar Quy
Quy - comment - 17 Feb 2023

Please fix spacing.

39872-media

avatar Kaushik1216
Kaushik1216 - comment - 17 Feb 2023

Please fix spacing.

39872-media

is this fine ? if yes I will made change in pr.

searchmsg

avatar Quy
Quy - comment - 17 Feb 2023

Yes except the following:

39872-spacing

avatar Kaushik1216
Kaushik1216 - comment - 18 Feb 2023

Yes except the following:

39872-spacing

Now I think fine

1asearch

But for it I have to write inline css .At later we can remove all incline css from this file

avatar Kaushik1216
Kaushik1216 - comment - 18 Feb 2023

@Quy @sandewt please test it again

avatar sandewt
sandewt - comment - 18 Feb 2023

Ok, but needs to be added in the messages (the link I shared)

#39872 (comment)

Which link? Resolved ?

avatar Kaushik1216
Kaushik1216 - comment - 18 Feb 2023

Ok, but needs to be added in the messages (the link I shared)

#39872 (comment)

Resolved ?

yes @dgrammatiko said me that I can use this string .

avatar Kaushik1216
Kaushik1216 - comment - 18 Feb 2023

can anyone tell me why build is falling ? in my system it's working fine

avatar laoneo
laoneo - comment - 22 Feb 2023

Can you revert the lock file?

avatar Kaushik1216
Kaushik1216 - comment - 22 Feb 2023

@laoneo @dgrammatiko @sandewt I have revert changes in lock please test this PR

avatar sandewt
sandewt - comment - 24 Feb 2023

I have tested successfully, but:
I have not done a .vue code review. That's not my expertise.
That's why I haven't set a flag yet.

avatar dgrammatiko
dgrammatiko - comment - 24 Feb 2023

@sandewt the Vue file is fine, mark your test as successful

avatar sandewt sandewt - test_item - 24 Feb 2023 - Tested successfully
avatar sandewt
sandewt - comment - 24 Feb 2023

I have tested this item successfully on 9fbd028


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39872.

avatar sandewt
sandewt - comment - 24 Feb 2023

the Vue file is fine, mark your test as successful

Done


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39872.

avatar Quy Quy - test_item - 24 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 24 Feb 2023

I have tested this item successfully on 9fbd028


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39872.

avatar Quy Quy - change - 24 Feb 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39872.

avatar Quy Quy - change - 24 Feb 2023
Labels Added: ?
avatar sandewt
sandewt - comment - 24 Feb 2023

Thanks all

avatar obuisard obuisard - close - 24 Feb 2023
avatar obuisard obuisard - merge - 24 Feb 2023
avatar obuisard obuisard - change - 24 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-24 22:29:52
Closed_By obuisard
avatar obuisard
obuisard - comment - 24 Feb 2023

Thank you @Kaushik1216 for the PR!

Add a Comment

Login with GitHub to post a comment