User tests: Successful: Unsuccessful:
Newfeature
Alternate pr for pr #39819
Summary of Changes
ADD a messge that will display when no result found on searching in media manager
Testing Instructions
Search in media manager
Actual result BEFORE applying this Pull Request
No message shown if no result match .
Expected result AFTER applying this Pull Request
A message will shown if result not match with search
Category | ⇒ | Administration com_media NPM Change |
Status | New | ⇒ | Pending |
@Kaushik1216 Does this replace your other PR #39819 ? If yes, then please close the other one. There should be a button on GitHub at the bottom of that PR to close it.
I have tested this item
See comment
You are almost there
Match source code (markup)
<div class="alert alert-info">
<span class="icon-info-circle" aria-hidden="true"></span><span class="visually-hidden"><?php echo Text::_('INFO'); ?></span>
<?php echo Text::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
</div>
[EDIT class="ms-2"
should be replaced by class="visually-hidden"
and so on]
we can not write php inside vue file it showing error
This is working fine see below :
Please test it on local system and run npm ci in CLI to compile js
This is working fine see below :
Indeed, but....
The idea is that the source code should match, look like this. For example, use the F12 key in FireFox to view the code.
Also see: #39819 (comment)
Category | Administration com_media NPM Change | ⇒ | Administration com_media NPM Change Front End Templates (site) |
Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
Category | Administration com_media NPM Change Front End Templates (site) | ⇒ | Administration com_media NPM Change |
I would expect here a closing tag? But see that it is not used in other places in this file.
Please your opinion @dgrammatiko
Line 39 -
Correct ?
<span
class="icon-info-circle"
aria-hidden="true"
/>
Or is this desired ?
<span
class="icon-info-circle"
aria-hidden="true"
>
</span>
I would expect here a closing tag? But see that it is not used in other places in this file.
This is a .vue
file and there's a special way that HTML elements are treated (similar to React's JSX). This is fine and actually if you write it as
<span
class="icon-info-circle"
aria-hidden="true"
>
</span>
you will get a notice from the linter
@dgrammatiko @sandewt please test now
Ok, but needs to be added in the messages (the link I shared)
Which link? Resolved ?
Ok, but needs to be added in the messages (the link I shared)
Resolved ?
yes @dgrammatiko said me that I can use this string .
can anyone tell me why build is falling ? in my system it's working fine
Can you revert the lock file?
@laoneo @dgrammatiko @sandewt I have revert changes in lock please test this PR
I have tested successfully, but:
I have not done a .vue code review. That's not my expertise.
That's why I haven't set a flag yet.
I have tested this item
the Vue file is fine, mark your test as successful
Done
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Thanks all
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-24 22:29:52 |
Closed_By | ⇒ | obuisard |
Thank you @Kaushik1216 for the PR!
@dgrammatiko please check why build it's falling Is it this from my side or what ?