[#39831] - [4.3] Media manager better breadcrumb
- Closed
- 13 Feb 2023
- Medium
- Build: 4.3-dev
- # 39831
- Diff
- dgrammatiko:4.3-dev-mm-better-breadcrump
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Switch breadcrumbs to select element to fix the width on many nested paths
Testing Instructions
- Apply the patch and run
npm ci - Check that the breadcrumbs work (try many nested folders)
Actual result BEFORE applying this Pull Request
Broken layout
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Also just for clarification, this should solve some a11y problems with breadcrumbs and the design and idea for the select menu comes directly from the Apple Finder (the File Explorer of MacOS):
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change JavaScript Repository |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
| Title |
|
||||||
Please fix for RTL.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39831.
@dgrammatiko I've just tested this PR but it seems not to work with keyboard navigation. When I tab to the breadcrumbs, I would expect it to open the dropdown when using the enter key, but it doesn't. So there is no way to use it for navigation with keyboard only.
When I tab to the breadcrumbs, I would expect it to open the dropdown when using the enter key,
I think you need to press space to open the dropdown and then use the arrow keys to select the one you want and then press enter. So there's an enter but at the end of the chain not in the start...
@dgrammatiko Ah, the space key was the trick. It seems only the skipto plugin uses the enter key, all our backend list views use space to open e.g. the list filters. So it's fine and consistent and just me did not know that.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39831.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39831.
all our backend list views use space to open
@richard67 actually this comes from the browser, it's the default accessibility mapping. Thus whenever we use the default select element we guarantee that the element is accessible (assuming that label, etc are in place)
| Labels |
Added:
?
|
||
I don't think so that this is a good change as breadcrumbs are displayed differently in joomla, where the full path is visible. With this change only the current path is listed which might work on desktop apps (honestly I don't like this behavior but that is another story) but never saw it on the web.
Do we even need breadcrumbs? Its just a duplication of the information in the tree
My personal opinion is that I like it, when I have an indicator where I'm actually navigated to with links without searching in the tree. Especially on smaller screens.
I am not in favour of this solution as it iis quite different from or usual braedcrumbs. Users expect that the behaviour of elements is consistent in a system.
I am not in favour of this solution as it iis quite different from or usual braedcrumbs.
Then fix the current one so it doesn't break even on huge screens:
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-13 10:55:43 |
| Closed_By | ⇒ | dgrammatiko |
Pleas make spacing consistent.