[#39746] - [4.3] Move the source of media manager (vue) to the build folder
- Closed
- 13 Feb 2023
- Medium
- Build: 4.3-dev
- # 39746
- Diff
- dgrammatiko:4.3-dev-mm-src
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- move the
administrator/com_media/resourcestobuild/media_source/com_media/__vue - add a conditional to skip any js files compiling if the path contains
__vue - adjust the vue compiling script
Testing Instructions
Apply the PR and run npm ci
Check that the media manager is still functional
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
The build tools docs were update to reflect this change
joomla-cms-bot
- | Category | ⇒ | Repository JavaScript NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
Honestly I would go the opposite way
I would also love to see that happen (but probably we're a minority). Also, to expand the idea the repo could be converted to mono repo and each component/module/plugin have it's own place, unlocking modular distributions and independent updates/versioning...
Since the above idea was shot down a few times in the past I just moved the js to the common place (which is awkward that media_source is not a root folder) just for consistency...
Anyways, if this is not improving things it should be closed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-13 10:58:03 |
| Closed_By | ⇒ | dgrammatiko |
Honestly I would go the opposite way and move all the js build file to the respective extension and create there a resource folder in them. Like that all the files are on the same place. Don't expecting this opinion will be shared by many?