? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
30 Jan 2023

Summary of Changes

The https://github.com/PHP-CS-Fixer/PHP-CS-Fixer project is another code style fixer for PHP which we have a config for since #10992 but actually never used. This pr integrates it into drone and fixes the code base, primarily adding a trailing comma on multiline arrays where phpcs has a big weakness.

On the other side the PHP CS Fixer can't properly handle files where HTML syntax is mixed with PHP code, so it makes sense to use both projects in our CI pipeline.

This pr is a result from #39739 (review).

This can be merged by review.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2023
Category Unit Tests Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact
avatar laoneo laoneo - open - 30 Jan 2023
avatar laoneo laoneo - change - 30 Jan 2023
Status New Pending
avatar laoneo laoneo - change - 30 Jan 2023
The description was changed
avatar laoneo laoneo - edited - 30 Jan 2023
avatar laoneo laoneo - change - 30 Jan 2023
Labels Added: ? PR-4.3-dev
e2db221 30 Jan 2023 avatar laoneo Test
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2023
Category Unit Tests Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact Unit Tests Administration com_admin com_associations com_banners com_cache
avatar HLeithner HLeithner - change - 31 Jan 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-31 10:19:58
Closed_By HLeithner
avatar HLeithner HLeithner - close - 31 Jan 2023
avatar HLeithner HLeithner - merge - 31 Jan 2023
avatar HLeithner
HLeithner - comment - 31 Jan 2023

Thanks

Add a Comment

Login with GitHub to post a comment