? Language Change NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
27 Jan 2023

Pull Request for Issue # .

Summary of Changes

  • Base work for the ordering
  • Supports: name, size, dimensions, date created and date modified

The TODO here is to expose to the icons view the ui (ie dropdown, series of buttons, etc) to control the ordering. Right now you have to switch to the table view to select another column for ordering...

Testing Instructions

Apply the PR and run npm ci

Check the grid layout of the media browser and click on the table headers

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Screenshot 2023-01-29 at 13 29 48
Screenshot 2023-01-29 at 13 30 11

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2023
Category Administration com_media NPM Change JavaScript
avatar dgrammatiko dgrammatiko - change - 27 Jan 2023
Status New Pending
avatar dgrammatiko dgrammatiko - open - 27 Jan 2023
avatar dgrammatiko dgrammatiko - change - 27 Jan 2023
Title
[4.3] Media Manager sorting
[4.3] Media Manager Ordering
avatar dgrammatiko dgrammatiko - edited - 27 Jan 2023
avatar dgrammatiko dgrammatiko - change - 27 Jan 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 27 Jan 2023
avatar dgrammatiko dgrammatiko - change - 27 Jan 2023
Labels Added: NPM Resource Changed PR-4.3-dev
be17b70 27 Jan 2023 avatar dgrammatiko meh
avatar dgrammatiko dgrammatiko - change - 28 Jan 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 28 Jan 2023
avatar Quy
Quy - comment - 29 Jan 2023

The Upload button is no longer working. Clicking it does nothing.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2023
Category Administration com_media NPM Change JavaScript Administration com_media NPM Change JavaScript Language & Strings
avatar dgrammatiko dgrammatiko - change - 29 Jan 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 29 Jan 2023
d7f16e6 29 Jan 2023 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - change - 29 Jan 2023
Labels Added: Language Change
avatar Quy
Quy - comment - 29 Jan 2023

Maybe change it to caret to match elsewhere. Also, the arrow is opposite direction compared to elsewhere.

39732

avatar dgrammatiko
dgrammatiko - comment - 29 Jan 2023

Maybe change it to caret to match elsewhere. Also, the arrow is opposite direction compared to elsewhere.

@Quy should be ok now

avatar Quy
Quy - comment - 29 Jan 2023

To be consistent elsewhere, the caret direction should reflect the current ordering.

avatar dgrammatiko
dgrammatiko - comment - 29 Jan 2023

To be consistent elsewhere, the caret direction should reflect the current ordering.

done

avatar Quy
Quy - comment - 29 Jan 2023

Sorry one minor change so the last word is not cut off. Make both dropdowns col-3.

39732-dropdown

avatar Quy Quy - test_item - 29 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 29 Jan 2023

I have tested this item successfully on 3becfe4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

avatar Quy
Quy - comment - 29 Jan 2023

Fix gap.

39741-gap

avatar Quy Quy - test_item - 29 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 29 Jan 2023

I have tested this item successfully on 366d186

THANK YOU!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

avatar viocassel viocassel - test_item - 29 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 29 Jan 2023

I have tested this item successfully on 366d186

?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

avatar Quy Quy - change - 29 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39732.

avatar obuisard obuisard - change - 29 Jan 2023
Labels Added: ?
avatar obuisard obuisard - change - 30 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-30 00:19:05
Closed_By obuisard
avatar obuisard obuisard - close - 30 Jan 2023
avatar obuisard obuisard - merge - 30 Jan 2023
avatar obuisard
obuisard - comment - 30 Jan 2023

Great PR. Thank you Dimitris @dgrammatiko.

Add a Comment

Login with GitHub to post a comment