Language Change NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar rajputanuj31
rajputanuj31
27 Jan 2023

Pull Request for Issue #31340

Summary of Changes

copied changes from previous PR #39518

Testing Instructions

Create a new folder in Media and open it (No files should be present)

Expected Result Before PR

No message

Expected Result After PR

A Drag and drop icon and a message will show

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2023
Category Administration com_media NPM Change Language & Strings
avatar rajputanuj31 rajputanuj31 - open - 27 Jan 2023
avatar rajputanuj31 rajputanuj31 - change - 27 Jan 2023
Status New Pending
avatar rajputanuj31 rajputanuj31 - change - 27 Jan 2023
Labels Added: Language Change NPM Resource Changed PR-4.3-dev
avatar dgrammatiko
dgrammatiko - comment - 27 Jan 2023

@rajputanuj31 change

to

v-if="listView === 'table' && !isEmpty"

change

to

v-else-if="listView === 'grid'  && !isEmpty"

Also instead of

<h4 v-if="isEmpty">
   {{ translate("COM_MEDIA_NO_MEDIA_FOUND") }}
 </h4>

we need something more to be inline with the other empty state pages, ie
Screenshot 2023-01-27 at 20 26 03

avatar laoneo
laoneo - comment - 28 Jan 2023

A message is ok for now. We can do a followup with a more enhanced screen.

avatar rajputanuj31
rajputanuj31 - comment - 28 Jan 2023

A message is ok for now. We can do a followup with a more enhanced screen.

I have almost completed it, will make a commit soon.

avatar rajputanuj31
rajputanuj31 - comment - 28 Jan 2023

Hey @dgrammatiko , @laoneo Is this fine? also where can I find related documentation for this issue.

mediano

avatar laoneo
laoneo - comment - 28 Jan 2023

Is this screen visible then for every folder which is empty? It can be that there is no documentation for it.

avatar rajputanuj31
rajputanuj31 - comment - 28 Jan 2023

Is this screen visible then for every folder which is empty? It can be that there is no documentation for it.

Yes it visible for every empty folders. Since no documentation for this issue so I will remove the Learn More link.

avatar dgrammatiko
dgrammatiko - comment - 28 Jan 2023

@rajputanuj31 sorry I miss guided you. What I meant was to refactor the drop state of the drag and drop to resemble the empty state for other components in Joomla. It doesn't have to be one to one the empty state of the other components

Screenshot 2023-01-28 at 12 03 41 (2)

avatar dgrammatiko
dgrammatiko - comment - 28 Jan 2023

@rajputanuj31 also please apply the requested changes above. Thanks

avatar rajputanuj31
rajputanuj31 - comment - 28 Jan 2023

@rajputanuj31 also please apply the requested changes above. Thanks

Here are the changes you've asked for.
image
Does this look good?

avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2023
Category Administration com_media NPM Change Language & Strings Administration com_media NPM Change
avatar rajputanuj31 rajputanuj31 - change - 28 Jan 2023
Labels Removed: Language Change
avatar rajputanuj31 rajputanuj31 - change - 29 Jan 2023
The description was changed
avatar rajputanuj31 rajputanuj31 - edited - 29 Jan 2023
avatar rajputanuj31
rajputanuj31 - comment - 29 Jan 2023

@dgrammatiko , @Quy , @laoneo please review my changes. Is there any more changes I need to make.

avatar dgrammatiko
dgrammatiko - comment - 29 Jan 2023

@rajputanuj31 personally I would go of something like

    <div
      v-if="isEmpty"
      class="text-center"
      style="display: grid; justify-content: center; align-content: center; height: 100%; margin-top: -1rem; color: var(--gray-200);"
    >
      <span
        class="fa-8x icon-cloud-upload upload-icon"
        aria-hidden="true"
      />
      <p>{{ translate("COM_MEDIA_DROP_FILE") }}</p>
    </div>

needs also

    /* The styles for the media-browser element */
    mediaBrowserStyles() {
      return {
        width: this.$store.state.showInfoBar ? '75%' : '100%',
        height: '100%',
      };
    },

Which results to a lighter icon/text and the icon and text are in the same position as the drag background.
Normal
Screenshot 2023-01-29 at 16 02 53

On drag
Screenshot 2023-01-29 at 16 03 02 2

avatar rajputanuj31
rajputanuj31 - comment - 29 Jan 2023

@dgrammatiko after applying your changes icon remains at top but I made some changes using css those I am commiting
image

avatar dgrammatiko
dgrammatiko - comment - 29 Jan 2023

@rajputanuj31 did you replace also the mediaBrowserStyles() as I wrote above?

avatar rajputanuj31
rajputanuj31 - comment - 29 Jan 2023

@rajputanuj31 did you replace also the mediaBrowserStyles() as I wrote above?

yes

avatar laoneo
laoneo - comment - 30 Jan 2023

Now we have a conflict here. Can you please check them, I guess the indentation of the tags has changed.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2023
Category Administration com_media NPM Change Administration com_admin com_categories com_finder com_media NPM Change com_menus Language & Strings JavaScript Repository com_tags Front End Installation Libraries
avatar rajputanuj31 rajputanuj31 - change - 30 Jan 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-01-30 11:08:50
Closed_By rajputanuj31
Labels Added: Language Change
avatar rajputanuj31 rajputanuj31 - close - 30 Jan 2023

Add a Comment

Login with GitHub to post a comment