User tests: Successful: Unsuccessful:
Pull Request for Issue #31340
copied changes from previous PR #39518
Create a new folder in Media and open it (No files should be present)
No message
A Drag and drop icon and a message will show
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration com_media NPM Change Language & Strings |
Status | New | ⇒ | Pending |
Labels |
Added:
Language Change
NPM Resource Changed
PR-4.3-dev
|
A message is ok for now. We can do a followup with a more enhanced screen.
A message is ok for now. We can do a followup with a more enhanced screen.
I have almost completed it, will make a commit soon.
Hey @dgrammatiko , @laoneo Is this fine? also where can I find related documentation for this issue.
Is this screen visible then for every folder which is empty? It can be that there is no documentation for it.
Is this screen visible then for every folder which is empty? It can be that there is no documentation for it.
Yes it visible for every empty folders. Since no documentation for this issue so I will remove the Learn More
link.
@rajputanuj31 sorry I miss guided you. What I meant was to refactor the drop state of the drag and drop to resemble the empty state for other components in Joomla. It doesn't have to be one to one the empty state of the other components
@rajputanuj31 also please apply the requested changes above. Thanks
@rajputanuj31 also please apply the requested changes above. Thanks
Category | Administration com_media NPM Change Language & Strings | ⇒ | Administration com_media NPM Change |
Labels |
Removed:
Language Change
|
@dgrammatiko , @Quy , @laoneo please review my changes. Is there any more changes I need to make.
@rajputanuj31 personally I would go of something like
<div
v-if="isEmpty"
class="text-center"
style="display: grid; justify-content: center; align-content: center; height: 100%; margin-top: -1rem; color: var(--gray-200);"
>
<span
class="fa-8x icon-cloud-upload upload-icon"
aria-hidden="true"
/>
<p>{{ translate("COM_MEDIA_DROP_FILE") }}</p>
</div>
needs also
/* The styles for the media-browser element */
mediaBrowserStyles() {
return {
width: this.$store.state.showInfoBar ? '75%' : '100%',
height: '100%',
};
},
Which results to a lighter icon/text and the icon and text are in the same position as the drag background.
Normal
@dgrammatiko after applying your changes icon remains at top but I made some changes using css those I am commiting
@rajputanuj31 did you replace also the mediaBrowserStyles()
as I wrote above?
@rajputanuj31 did you replace also the
mediaBrowserStyles()
as I wrote above?
yes
Now we have a conflict here. Can you please check them, I guess the indentation of the tags has changed.
Category | Administration com_media NPM Change | ⇒ | Administration com_admin com_categories com_finder com_media NPM Change com_menus Language & Strings JavaScript Repository com_tags Front End Installation Libraries |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-30 11:08:50 |
Closed_By | ⇒ | rajputanuj31 | |
Labels |
Added:
Language Change
|
@rajputanuj31 change
joomla-cms/administrator/components/com_media/resources/scripts/components/browser/browser.vue
Line 20 in cc4bdae
change
joomla-cms/administrator/components/com_media/resources/scripts/components/browser/browser.vue
Line 73 in cc4bdae
Also instead of
we need something more to be inline with the other empty state pages, ie