[#39727] - [4.3][csp] Remove inline onclick from the Help button
- Fixed in Code Base
- 29 Jan 2023
- Medium
- Build: 4.3-dev
- # 39727
- Diff
- dgrammatiko:4.3-dev-csp-toolbar
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Deprecate
Joomla.popupWindow - Use data attributes to pass the data from PHP to JS
- Add the required onclick functionality based on the data attributes
Testing Instructions
This pr needs npm ci
Check any page on the backend with a help button that when clicking on it the help window opens as expected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Where do we register the deprecations?
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-29 19:55:27 |
| Closed_By | ⇒ | obuisard |
Thank you Dimitris @dgrammatiko !
@dgrammatiko @viocassel @Quy
Are you sure this is working? If I click the help button then it will open this url (notice the escaped slashes)
the Microsoft Edge (Version 111.0.1661.54) the second one is replaced to two slashes
and I will be redirected to the Main Page
Without this PR the url is correct (but not working at the moment for J4.3)
We are working with the documentation team to resolve the missing docs for 4.3.
I have tested this item✅ successfully on e1e6e6e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727.