[#39726] - [4.3][csp] Reduce inline onchange usage [searchtools]
- Fixed in Code Base
- 29 Jan 2023
- Medium
- Build: 4.3-dev
- # 39726
- Diff
- dgrammatiko:4.3-dev-csp-searchtools
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- remove the filter xml entries
onchange="this.form.submit();" - add a class
js-select-submit-on-changeon their place - Tweet the search tools javascript to replicate the functionality for each element with the class
Testing Instructions
This PR needs npm ci
Pick a list view and check that all the filters are working as before (ie selecting anything with a select element and observe the page refreshing)
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_fields com_finder com_installer com_languages com_menus |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39726.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39726.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39726.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-29 21:54:00 |
| Closed_By | ⇒ | obuisard |
Thank you Dimitris @dgrammatiko !
@dgrammatiko Can you please look into Menus > Manage and toggle Site/Administrator dropdown not updating? Thanks.
@dgrammatiko Can you please look into Menus > Manage and toggle Site/Administrator dropdown not updating? Thanks.
Will do a PR later on today, thanks for reporting it
I think this is fine. But we are definitely going to need to document all these magic classes if we expect extensions to adopt this as part of CSP implementation of the backend.