/me dancing with joy

Looking good - two small issues

1. When using the new button I expected to get a message saying "the email has been sent" or something like that
2. The email that is sent is just the language keys not the values
   

Guessing that you need to copy the language strings from the site language file to the admin language file

or maybe the issue is that its not using the mail template

My bad, I totally forgot the "mail sent" notification.

The other issue is weird, that worked for me in local. I will do a fresh Joomla install and check from there, maybe I had some changes made in the repo I was using...but still weird, somehow the mailer is not loading the strings..

I will check later this

@brianteeman Okay you was right, the com_users.ini language loaded was only from the administrator part, as is expected.

So adding the follow:

// Load com_users site language strings
$language = $app->getLanguage();
$language->load('com_users', JPATH_SITE);

Fix the problem. But I really not like this solution. The best approch is just copy the strings to the administrator .ini language file. Is okay do it like this?

How do the other com_users admin emails do it?
Is it perhaps because you are not using the new mail templates?

Is it perhaps because you are not using the new mail templates?

I using it, yes:

$mailer = new \Joomla\CMS\Mail\MailTemplate('com_users.registration.user.admin_activated', $app->getLanguage()->getTag());
$mailer->addTemplateData($mailData);
$mailer->addRecipient($userMail);

How do the other com_users admin emails do it?

They have all the string in the administrator .ini file

They have all the string in the administrator .ini file

I cant see them

from here:

Those are not the email strings. These are

Right, I though you meant the one used in the actions in the administrator.

The first 2 strings are used in the users registration Model in the site part

The rest are actions triggered by a normal user, also in the site part.

When using the new button I expected to get a message saying "the email has been sent" or something like that

Done (new string added)

The email that is sent is just the language keys not the values

Done

Last changes all look good. One more thing

The button should not be displayed at all when $isNew

Last changes all look good. One more thing

Done. And don't worry, while more corrections the better. Thank you for the help in this.

Last changes all look good. One more thing

Done. And don't worry, while more corrections the better. Thank you for the help in this.

Purely self motivated as I need this functionality and currently I just have an ugly hack

I have tested this item ✅ successfully on 8edcee8

Maybe hide the Send Activation Reminder button when lastvisitDate is not null. Currently, clicking on it appears to do nothing and no message.

@Quy thank you, I was asking the wrong question in that check. Now is okay

Please do not merge, the branch is in 'freeze' state until Tuesday. Thank you!

@obuisard is this ready to merge? or is 4.3 closed again?

@HLeithner It needs 2 human tests again as it has been changed after tests.

As we're in feature freeze, it's for 4.4.

4.4 doesn't get new features?

Feature freeze your xcept for the priviliged few.

So that means that the guided tour component that @obuisard and others have been working hard will not be nmerged until 2024

4.4 doesn't get new features?

@HLeithner I guess you wanted to ask about 4.3.

no 4.4 is a bridge release without new features like joomla 3.10

no 4.4 is a bridge release without new features like joomla 3.10

Ah, yes, I forgot, but now I remember.

So according to the extended definition of a feature to include anythingn that is not an error that means that nothing new will happen in Joomla until 2024?

5.0 is planned for mid October 2023

4.4 doesn't get new features?

Yes, you're right, as it's in parallel, i mixed it up. I mean of course 5.0.

Feature freeze your xcept for the priviliged few.

Yup, there are some exceptions, where the one or other already benefit from, by getting more time to finish a feature, sometimes till Beta 3.

A few months ago, the planned development was too fast, now it's too slow, one never can make it right....

just asking for consistency. noting that the guided tours is still not ready

Thank you for your contribution, unfortunately the 4.4-dev branch doesn't get new features. When #40181 is merged this pr should be rebased to 5.0-dev. Thanks for understanding.

I have tested this item 🔴 unsuccessfully on 3edd0e6

At step 2 in the test I get this:

An error has occurred.

    0 There is no "com_users.activate-user-send-email" asset of a "script" type in the registry. 

Call stack
# 	Function 	Location
1 	() 	JROOT/libraries/src/WebAsset/WebAssetRegistry.php:134
2 	Joomla\CMS\WebAsset\WebAssetRegistry->get() 	JROOT/libraries/src/WebAsset/WebAssetManager.php:263
3 	Joomla\CMS\WebAsset\WebAssetManager->useAsset() 	JROOT/libraries/src/WebAsset/WebAssetManager.php:197
4 	Joomla\CMS\WebAsset\WebAssetManager->__call() 	JROOT/administrator/components/com_users/tmpl/user/edit.php:26
5 	include() 	JROOT/libraries/src/MVC/View/HtmlView.php:415
6 	Joomla\CMS\MVC\View\HtmlView->loadTemplate() 	JROOT/libraries/src/MVC/View/HtmlView.php:203
7 	Joomla\CMS\MVC\View\HtmlView->display() 	JROOT/administrator/components/com_users/src/View/User/HtmlView.php:133
8 	Joomla\Component\Users\Administrator\View\User\HtmlView->display() 	JROOT/libraries/src/MVC/Controller/BaseController.php:697
9 	Joomla\CMS\MVC\Controller\BaseController->display() 	JROOT/administrator/components/com_users/src/Controller/DisplayController.php:130
10 	Joomla\Component\Users\Administrator\Controller\DisplayController->display() 	JROOT/libraries/src/MVC/Controller/BaseController.php:730
11 	Joomla\CMS\MVC\Controller\BaseController->execute() 	JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
12 	Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() 	JROOT/libraries/src/Component/ComponentHelper.php:361
13 	Joomla\CMS\Component\ComponentHelper::renderComponent() 	JROOT/libraries/src/Application/AdministratorApplication.php:150
14 	Joomla\CMS\Application\AdministratorApplication->dispatch() 	JROOT/libraries/src/Application/AdministratorApplication.php:195
15 	Joomla\CMS\Application\AdministratorApplication->doExecute() 	JROOT/libraries/src/Application/CMSApplication.php:306
16 	Joomla\CMS\Application\CMSApplication->execute() 	JROOT/administrator/includes/app.php:58
17 	require_once() 	JROOT/administrator/index.php:32 

@ceford Also this PR here has conflicts shown on GitHub.

This pull request has been automatically rebased to 5.1-dev.

I tried to solve the conflicts in this PR. @carlitorweb can you check if it is correct the way I did it?

@Hackwar this is on my todo list for the morning.

Could you fix the unused import that phpcs has highlighted

I have tested this item ✅ successfully on 6f8fe41

Other than the minor cs issue this works perfectly!!!

I have tested this item ✅ successfully on f5cf34a

This pull request has been automatically rebased to 5.2-dev.

I have tested this item ✅ successfully on f5cf34a

Works,
but the activated-email to the new user comes in the backend-language of the "Super User" who
click to the button"Activate & Send Email" or "Send Activation Reminder"-button,
and not in the default-language of the website as the registration-emails.

The registration-emails comes with this PR and without this PR in the default-language of the website.

default-language:
https://help.joomla.org/proxy?keyref=Help51:Languages:_Installed

RTC

Back to pending due to merge conflicts.

RTC

@richard67 how can this be RTC when we have this comment #39650 (comment)

@richard67 how can this be RTC when we have this comment #39650 (comment)

@brianteeman Why does @Sieger66 then post a successful test result if it is not successful?

@carlitorweb Is it intended that the email goes out in the backend language of the admin user?

Back to pending due to necessary clarification.

I can't speak for @Sieger66

What I have observed in other test reports is -" i tested this according to the instructions and it did what it said" but I also think

• its a bad idea
• its missing x
• y happens now

The current system doesnt really allow for that.

Note: Remember when you install a new language and you want to use the mail template, is neccessary go to the Mail Template section, enter to the template you want to use and save it. Doing this, then the proper tag is generated in the language column of the mail_templates table. If not, always will fallback to en-GB

I have tested this item 🔴 unsuccessfully on b13a47a

After your last commit the com_users.registration.user.admin_activated - email comes only with the two language-Strings in the email:
in subject is only "COM_USERS_EMAIL_ACTIVATED_BY_ADMIN_ACTIVATION_SUBJECT"
in body is only "COM_USERS_EMAIL_ACTIVATED_BY_ADMIN_ACTIVATION_BODY"

Then i go to the Mail Template section to "com_users.registration.user.admin_activated" email-template
and click to save in german and english language version.(Only this two languages are installed in the website)
Now the com_users.registration.user.admin_activated - email comes with the correct text but ever in the english language in the email!
The default-language of the website and the "administrator backend-language" have no affect to the language in this email.
I think that is not correct.

All other "registration-emails" for example:
com_users.registration.user.admin_activation
com_users.registration.admin.verification_request
comes in the default-language of the website.

default-language:
https://help.joomla.org/proxy?keyref=Help51:Languages:_Installed

@Sieger66 We have 2 default language param, one is for the administrator and the other is for the frontend. Right now, the email go out with the default language of the administrator.

If I understand well, what you looking for is, the email go out with the default language of the frontend, is this correct?

Yes, this is correct.
Ohh! I now see the default-language param for the administrator and
the email go out with the default language of the administrator.
In detail the "com_users.registration.user.admin_activated" email comes allways with this language with your last commit.
But the other emails comes in the language of the default-language param for the site.

I dont know is it intended and is it correct usecase.

Other small issue:
In the sent notification message in backend comes only the language-key:
COM_USERS_REGISTRATION_ACTIVATION_NOTIFY_SEND_MAIL_SUCCESS
and not the value(text).

@Sieger66 issue fixed

Now the email will go out with the site default language.

I have tested this item ✅ successfully on c375030

Works as aspected.
@brianteeman : Now we need a second test.