Feeling Lucky
?
PR-4.3-dev
[#39649] - [4.3] Converts editor buttons to service providers
- Fixed in Code Base
- 19 Jan 2023
- Medium
- Build: 4.3-dev
- # 39649
- Diff
- dgrammatiko:4.3-dev-xtd-btns
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Move all editor buttons except page break (for testing purposes) to service providers
Testing Instructions
- Apply the PR
- Delete the file
administrator/cache/autoload_psr4.php - Check that all buttons work correctly for all the editors (tinyMCE, Codemirror, None)
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
PR-4.3-dev
|
||
laoneo
- comment
- 18 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649.
viocassel
- comment
- 18 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 18 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-19 02:09:24 |
| Closed_By | ⇒ | obuisard |
obuisard
- comment
- 19 Jan 2023
Thank you Dimitris @dgrammatiko :-)
I'm just wondering if the namespace should be a bit more clear. I know they are inline with the rest, but Xtd doesn't say much. Why not just going with Joomla\Plugin\EditorButton\Article.