Feature ? Documentation Required NPM Resource Changed PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jan 2023

This simple PR adds a keyboard shortcut to open the source code editor when in tinymce

On Windows the key is ALT-U
On Mac the key is OPTION-U

Testing Instructions

This is a js change so either test with a prebuilt package or apply the pr and then npm run build:js

Actual result BEFORE applying this Pull Request

Nothing

Expected result AFTER applying this Pull Request

Pressing the key opens the code editor

Link to documentations

None - yet - needs documentation for the entire code editor plugin to be written AND link to that documentation to be added to tinymce.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2023
Category JavaScript Repository NPM Change
avatar brianteeman brianteeman - open - 16 Jan 2023
avatar brianteeman brianteeman - change - 16 Jan 2023
Status New Pending
avatar Quy Quy - test_item - 18 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 18 Jan 2023

I have tested this item successfully on 48478f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39644.

avatar sandewt
sandewt - comment - 19 Jan 2023

On Windows the key is ALT-U

You mean instead of clicking the 'Toggle Editor' in 'Articles: Edit' mode ?
In that case nothing happens in Windows.

avatar brianteeman
brianteeman - comment - 19 Jan 2023

On Windows the key is ALT-U

You mean instead of clicking the 'Toggle Editor' in 'Articles: Edit' mode ? In that case nothing happens in Windows.

No - I mean instead of clicking on the <> button

It was developed on windows ;)

avatar sandewt sandewt - test_item - 19 Jan 2023 - Tested successfully
avatar sandewt
sandewt - comment - 19 Jan 2023

I have tested this item successfully on 48478f9

Tested on WINDOWS and NOT on a MAC
Browsers: Firefox and Edge


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39644.
avatar Quy Quy - change - 19 Jan 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 19 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39644.

avatar Quy Quy - change - 19 Jan 2023
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Feb 2023
Labels Added: Documentation Required NPM Resource Changed
avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar brianteeman brianteeman - change - 8 May 2023
Title
[4.3] Tinymce Source Code Editor shortcut
[5.0] Tinymce Source Code Editor shortcut
avatar brianteeman brianteeman - edited - 8 May 2023
avatar HLeithner HLeithner - change - 15 Jun 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-15 06:43:20
Closed_By HLeithner
Labels Added: Feature PR-5.0-dev ?
Removed: PR-4.3-dev
avatar HLeithner HLeithner - close - 15 Jun 2023
avatar HLeithner HLeithner - merge - 15 Jun 2023
avatar HLeithner
HLeithner - comment - 15 Jun 2023

thanks

Add a Comment

Login with GitHub to post a comment