Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39643] - Popovers replaced by Tooltips in Category list in Cassiopeia #35467

? ? Maintainers Checked Pending

User tests: Successful: Unsuccessful:

avatar charvimehradu
charvimehradu
16 Jan 2023

Pull Request for Issue #35467.

Summary of Changes

Changed popovers to tooltips

Testing Instructions

Have a look on the category list in Cassiopeia with blog sample data

Actual result BEFORE applying this Pull Request

131897635-fbc014c6-d871-4458-913e-3b7dfee86a75

Expected result AFTER applying this Pull Request

test output

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2023
Category ⇒ Libraries
avatar charvimehradu charvimehradu - open - 16 Jan 2023
avatar charvimehradu charvimehradu - change - 16 Jan 2023
Status New ⇒ Pending
avatar charvimehradu charvimehradu - change - 16 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 16 Jan 2023
avatar charvimehradu charvimehradu - change - 16 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 16 Jan 2023
avatar laoneo laoneo - change - 16 Jan 2023
The description was changed
avatar laoneo laoneo - edited - 16 Jan 2023
avatar charvimehradu charvimehradu - change - 16 Jan 2023
Title
…
testing
Popovers replaced by Tooltips in Category list in Cassiopeia #35467
avatar charvimehradu charvimehradu - edited - 16 Jan 2023
avatar charvimehradu charvimehradu - change - 16 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 16 Jan 2023
avatar charvimehradu charvimehradu - change - 16 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 16 Jan 2023
avatar brianteeman
brianteeman - comment - 16 Jan 2023

this is a library change that will impact everywhere that HTMLHelper::_('grid.sort is used

@roland-d @obuisard I think that as a result this can only go in 4.3 but possibly only in 5

avatar roland-d
roland-d - comment - 16 Jan 2023

This is definitely not for 4.2 as this is not a bugfix. The bigger question I guess is, do we want to change popovers to tooltips? In case we go to tooltips, we may want it everywhere for consistency.

@wilsonge Do you know/remember why we went to popovers? As I remember we used to have tooltips.

avatar chmst
chmst - comment - 20 Jan 2023

@roland-d I don't know why but in J4 we have only tooltips, no popovers. Maybe due to bootstrap jQuery.

There were only three popovers left in J4, one of them is this one.
For me it is more a bugfix that a new feature.

avatar roland-d roland-d - change - 15 Feb 2023
Labels Added: ? Maintainers Checked
avatar roland-d
roland-d - comment - 15 Feb 2023

@chmst

There were only three popovers left in J4, one of them is this one.

Ok, good to know. In that case it is a bugfix indeed. We will need testers for this issue.

avatar ChristineWk
ChristineWk - comment - 18 Feb 2023

screen shot 2023-02-18 at 15 13 11

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39643.

avatar ChristineWk ChristineWk - test_item - 18 Feb 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 18 Feb 2023

I have tested this item ✅ successfully on f073224

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39643.

avatar ChristineWk ChristineWk - test_item - 22 Feb 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 22 Feb 2023

I have tested this item ✅ successfully on c8459ee

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39643.

avatar Quy Quy - test_item - 22 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 22 Feb 2023

I have tested this item ✅ successfully on c8459ee

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39643.

avatar Quy Quy - change - 22 Feb 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 22 Feb 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39643.

avatar fancyFranci fancyFranci - close - 24 Feb 2023
avatar fancyFranci fancyFranci - merge - 24 Feb 2023
avatar fancyFranci fancyFranci - change - 24 Feb 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-24 23:12:51
Closed_By ⇒ fancyFranci
Labels Added: ?
avatar fancyFranci
fancyFranci - comment - 24 Feb 2023

Thank you. It looks much better now :)

Add a Comment

Login with GitHub to post a comment