[#39575] - Naming inconsistency within AssociationServiceTrait
- New
- Low
- Build: 4.2.5
- # 39575
There is a naming inconsistency in the method names in \libraries\src\Association\AssociationServiceTrait.php
The getter is called getAssociationsExtension() with an s at the end of Association
The setter is called setAssociationExtension() without an s at the end of Association
Not sure if you feel this warrants getting fixed or not!
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
@brianteeman can you please stop reporting every comment of @wojtekxtx it's really offending against maintainers
I was thinking that one possibility would be to add a new function into the trait, one that had the name you wanted to use long term. Then mark the other one as deprecated, to be removed in some release. That way 3rd party developers would have some warning that it would disappear, and new developments could use the right name from the outset.
It would be ugly for a while, but would enable you to end up with a tidy solution
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39575.
@laoneo is there somewhere (early) roadmap for
6.0or is it too early for this?
No there isn't. But our updated deprecation policy demands, that we have to add deprecations for the for the over next major release. So when you deprecate something in a 4 minor release, then the earliest release is 6.0 where it is planned to get removed. This gives extension developers enough time to update their extensions, especially as we have now timed releases, where a new major will come out every two years.
Hackwar
- | Labels |
Added:
bug
|
||
#Excellent catch @robbiejackson✅