Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39576] - Firefox subform drag fix

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar JackKellyUK
JackKellyUK
8 Jan 2023

Pull Request for Issue #37974.

Summary of Changes

Issue looks to be caused by a bug with Firefox

Reworked subform drag button styling, increasing span click area to circumvent browser bug.

Testing Instructions

Test in multiple browsers including Firefox

  1. Open the 'System - HTTP Headers' plugin
  2. Add at least 2 subform fields to 'Force HTTP Headers'
  3. Check drag button functions correctly

Actual result BEFORE applying this Pull Request

Only part of the subform drag button functioned in Firefox

Expected result AFTER applying this Pull Request

Drag button is fully clickable in all browsers

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 8 Jan 2023
Category ⇒ Repository NPM Change
avatar JackKellyUK JackKellyUK - open - 8 Jan 2023
avatar JackKellyUK JackKellyUK - change - 8 Jan 2023
Status New ⇒ Pending
avatar JackKellyUK JackKellyUK - change - 8 Jan 2023
Labels Added: NPM Resource Changed ?
avatar Quy Quy - test_item - 3 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 3 Feb 2023

I have tested this item ✅ successfully on f6021cf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39576.

avatar HLeithner
HLeithner - comment - 12 Feb 2023

@dgrammatiko can you have a look at this?

avatar dgrammatiko dgrammatiko - test_item - 12 Feb 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 12 Feb 2023

I have tested this item ✅ successfully on f6021cf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39576.

avatar Quy Quy - change - 12 Feb 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 12 Feb 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39576.

avatar Quy Quy - change - 12 Feb 2023
Labels Added: ?
avatar roland-d roland-d - change - 23 Feb 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-23 07:14:43
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 23 Feb 2023
avatar roland-d roland-d - merge - 23 Feb 2023
avatar roland-d
roland-d - comment - 23 Feb 2023

Thank you

Add a Comment

Login with GitHub to post a comment