[#39574] - [4.2] Clean the logo URL in Cassiopeia
- Fixed in Code Base
- 10 Jan 2023
- Medium
- Build: 4.2-dev
- # 39574
- Diff
- dgrammatiko:4.2-dev-cassiopeia-logo
User tests: Successful: Unsuccessful:
Pull Request for Issue #39571, #39538, #39543
Summary of Changes
Use the recommended way to render an image: through the HTMLHelper
Testing Instructions
Check that selecting a custom logo image works and that the source doesn't have the hash part of the URL. Also check that svg renders as expected
Actual result BEFORE applying this Pull Request
The URL contains the hash (it is dirty) and SVG images get 0 width and height thus are not visible
Expected result AFTER applying this Pull Request
The URL does not contain the hash (it is clean) and SVG images are visible
Link to documentations
This is a bug fix without changing any of the existing functionality
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
The double slashes is fixed, however, the image won't display even though the markup is there. Adding a width attribute displays the image.
<img loading="eager" decoding="async" src="http://localhost/joomla-cms-4.2-dev/images/logo.svg" alt="J42">
however, the image won't display even though the markup is there. Adding a width attribute displays the image.
Ok, this could be solved either with CSS (patch) or the media manager needs to pass the correct size when an svg is selected (proper solution). I would make a PR for the second option.
This PR is still valid as it cleans the URL #...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39574.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39574.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39574.
@Quy @viocassel thanks for testing this one. #39586 is the last missing part (the one I wrote about here: #39574 (comment)) and would be awesome if you could test that one as well. Mille grazie
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-10 19:29:26 |
| Closed_By | ⇒ | roland-d |
Thank you
Double
//. Also image does not display on the frontend.