? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar JackKellyUK
JackKellyUK
8 Jan 2023

Pull Request for Issue #38991.

Summary of Changes

Converted read more alert to joomla-alert (not sure if this should be a warning instead of error).

Testing Instructions

  1. Create a new Article
  2. Insert a read more
  3. Attempt to insert another read more
  4. Verify message string

Actual result BEFORE applying this Pull Request

Message displayed in js alert with broken ellipses

Expected result AFTER applying this Pull Request

Message displayed within Joomla's message system correctly

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 8 Jan 2023
Category JavaScript Repository NPM Change
avatar JackKellyUK JackKellyUK - open - 8 Jan 2023
avatar JackKellyUK JackKellyUK - change - 8 Jan 2023
Status New Pending
avatar JackKellyUK JackKellyUK - change - 8 Jan 2023
Labels Added: NPM Resource Changed ?
avatar brianteeman brianteeman - test_item - 12 Jan 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Jan 2023

I have tested this item successfully on c5c2f9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39573.

avatar viocassel viocassel - test_item - 12 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 12 Jan 2023

I have tested this item successfully on c5c2f9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39573.

avatar Quy Quy - change - 12 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39573.

avatar roland-d roland-d - change - 12 Jan 2023
Labels Added: ?
avatar roland-d roland-d - change - 12 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-12 18:42:49
Closed_By roland-d
avatar roland-d roland-d - close - 12 Jan 2023
avatar roland-d roland-d - merge - 12 Jan 2023
avatar roland-d
roland-d - comment - 12 Jan 2023

Thank you

Add a Comment

Login with GitHub to post a comment