[#39079] - Migrate qn function to quoteName for phan
- Fixed in Code Base
- 27 Oct 2022
- Medium
- Build: 4.3-dev
- # 39079
- Diff
- wilsonge:phan_analysis
User tests: Successful: Unsuccessful:
Summary of Changes
Phan requires function names to be in the interface so migrates our functions from the alias's to the functions that are inside the interfaces without changing functionality
The only change beyond function names is removing the AS functionality in this single place https://github.com/joomla/joomla-cms/compare/4.3-dev...wilsonge:phan_analysis?expand=1#diff-617530abeea53181b5e5f641ba3906dcbf758238861e8a5281422722533d8532R1487
Testing Instructions
Code review and review the phan analysis
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_joomlaupdate Libraries Front End Plugins |
| Labels |
Added:
PR-4.3-dev
|
||
PhanUndeclaredMethod Call to undeclared method \Joomla\Database\DatabaseInterface::qn
is the error we’re looking to fix here
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-27 11:13:58 |
| Closed_By | ⇒ | rdeutz |
Would be good to know for which error message to check in the phan log in drone.