[#39080] - Fix PHPCS from Security Fix
- Fixed in Code Base
- 26 Oct 2022
- Medium
- Build: 4.2-dev
- # 39080
- Diff
- joomla:security-phpcs-fix
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes improperly applied fix from the security repo (thanks @richard67 for finding this when doing #39075 and securely raising this when he realised)
Unfortunately the fix from @joomla/security wasn't correctly applied to this repo when combining the 3 parts of the fix. Luckily the important parts were fixed and it's been agreed to fix 'the fix' in the public domain.
This moves the protected keys to the more secure version in the main plugin class, therefore fixing the PHPCS failure too.
Testing Instructions
Ensure drone checks now pass, ensure the debug plugin continues to work and only display the correct results in the previous requests log and also displays no secrets in the request data logs
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
@richard67 from what i can see that namespace should not be a problem. Restarted drone to see if it errors out in the same place.
| Labels |
Added:
Release Blocker
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-26 17:36:06 |
| Closed_By | ⇒ | bembelimen |
Thx
@wilsonge Any idea why api tests are failing in drone? Maybe the global namespace is wrong?