Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#38935] - Fix order of items not always saved

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 Oct 2022

Pull Request for Issue #38910 .

Summary of Changes

Use input.value = x, instead of input.setAttribute('value', x)

Testing Instructions

Apply patch, run npm install.

And follow #38910 , or:

Open sample data menus list for Top menu.
Drag "Fruit Shop" to:
3-d position, check frontend - position should change,
then drag to 5-th position, check fronted - position stays 3-rd
Important: do not reload the menu list page.

Actual result BEFORE applying this Pull Request

Order randomly saved wrongly

Expected result AFTER applying this Pull Request

Order always saved

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Fedik Fedik - open - 11 Oct 2022
avatar Fedik Fedik - change - 11 Oct 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2022
Category ⇒ JavaScript Repository NPM Change
avatar wwwiiimmm
wwwiiimmm - comment - 12 Oct 2022

I have tested this item ✅ successfully on b460ee4

I used the Custom URL in Joomla Updater to install this PR.
After that I dragged menu items and featured articles to different possitions.

From what I can see this fixes the order issue.

Thank you.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38935.

avatar wwwiiimmm wwwiiimmm - test_item - 12 Oct 2022 - Tested successfully
avatar richard67
richard67 - comment - 12 Oct 2022

I have tested this item ✅ successfully on b460ee4

I could reliably reproduce the issue. It always failed for me when I dragged an item to the very last position of the menu items list. I can confirm the patch solves this.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38935.

avatar richard67 richard67 - test_item - 12 Oct 2022 - Tested successfully
avatar richard67 richard67 - change - 12 Oct 2022
Status Pending ⇒ Ready to Commit
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 12 Oct 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38935.

avatar HLeithner HLeithner - close - 15 Oct 2022
avatar HLeithner HLeithner - merge - 15 Oct 2022
avatar HLeithner HLeithner - change - 15 Oct 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-10-15 08:18:50
Closed_By ⇒ HLeithner
Labels Added: ?

Add a Comment

Login with GitHub to post a comment