[#38934] - [4.2] Provide a fallback for the persisted url for the Media Manager
- Fixed in Code Base
- 1 Dec 2022
- Medium
- Build: 4.2-dev
- # 38934
- Diff
- dgrammatiko:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Provide a reasonable fallback for the client side persisted state of the current folder
Testing Instructions
- Open Media manager
- navigate to
images/sampledata/cassiopeia - Open the browser dev tools
- Open to the tab
Application(or Storage for Safari)
- Edit the session storage from
selectedDirectory: "local-images:/sampledata/cassiopeia"toselectedDirectory: "local-none:/sampledata/cassiopeia"
-Reload the page (F5 or clicking the refresh button of the browser)
Actual result BEFORE applying this Pull Request
Broken
Expected result AFTER applying this Pull Request
Fallback to the root of the drive or fallback to the first available drive
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.
| Labels |
Added:
?
|
||
I did now restart drone two times and both times it failed on the same test showsFilesAndFoldersOfASubdirectoryWhenOpenedUsingDeepLink. @dgrammatiko can you have a look if this pr breaks the test?
I don't think so. Can you please check why the test is failing? I would like to get this one merged.
Can you please check why the test is failing
Could you send me the error log of the the CI?
On this linke scroll to the bottom https://ci.joomla.org/joomla/joomla-cms/59712/1/32. The artefacts can be found here https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/38934/system-tests/59712/.
Rarely this happens in Joomla land...
I can't get the first part of the test to work. When I change local-images to local-none and reload, the page reloads normally and the session storage is back to local-images. This with Firefox and Chrome on Mac. What have I misunderstood?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.
@ceford this is how it should be. If you do that on a joomla installation without the patch, then it breaks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.
@viocassel Could you please test again? There where some changes in the script. Would be great to have it in the coming release.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-12-01 21:51:39 |
| Closed_By | ⇒ | fancyFranci |
Thank you! Great that you improved the media manager :)
I have tested this item✅ successfully on 9a05ac5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38934.