? ? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar antonbag
antonbag
21 Sep 2022

Pull Request for Issue # .

Summary of Changes

Filter by featured and filter by tag included

Testing Instructions

In postman, GET {{base_url}}/{{base_path}}/content/articles?filter[featured]=1
In postman, GET {{base_url}}/{{base_path}}/content/articles?filter[tag]=1

Actual result BEFORE applying this Pull Request

No filtered by featured nor tag

Expected result AFTER applying this Pull Request

Filter articles by featured and/or tag

Documentation Changes Required

avatar antonbag antonbag - open - 21 Sep 2022
avatar antonbag antonbag - change - 21 Sep 2022
Status New Pending
avatar antonbag antonbag - change - 22 Sep 2022
Labels Added: ?
avatar alikon
alikon - comment - 26 Sep 2022

your change didn't have only filter[featured] but filter[tag] too please update test instructions

avatar antonbag antonbag - change - 28 Sep 2022
Labels Added: ?
avatar antonbag antonbag - change - 28 Sep 2022
The description was changed
avatar antonbag antonbag - edited - 28 Sep 2022
avatar alikon
alikon - comment - 21 Oct 2022

I have tested this item successfully on 78429ae


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38798.

avatar alikon alikon - test_item - 21 Oct 2022 - Tested successfully
avatar ReLater
ReLater - comment - 22 Nov 2022

filter[tag]=1

What does that mean? "Has a tag" or is that a tag id?

avatar antonbag
antonbag - comment - 22 Nov 2022

filter[tag]=1

What does that mean? "Has a tag" or is that a tag id?

Is a tag id

avatar ReLater ReLater - test_item - 22 Nov 2022 - Tested successfully
avatar ReLater
ReLater - comment - 22 Nov 2022

I have tested this item successfully on 1c5a5fa

Tested with Linux console and several combinations like

$ token=c2hhMjU2OjM0MDo0MjExNzY2MmIzZDIwMzU2YzIw...
$ url="https://example.org/api/index.php/v1/content/articles?"
$ curl -H "Authorization: Bearer $token" $url"filter\[tag\]=3"

$ curl -H "Authorization: Bearer $token" $url"filter\[featured\]=1"

$ curl -H "Authorization: Bearer $token" $url"filter\[featured\]=1&filter\[tag\]=2"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38798.
avatar Quy Quy - alter_testresult - 23 Nov 2022 - alikon: Tested successfully
avatar Quy Quy - change - 23 Nov 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 23 Nov 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38798.

avatar laoneo laoneo - change - 23 Nov 2022
Labels Added: ?
avatar laoneo
laoneo - comment - 23 Nov 2022

Thanks @antonbag for this nice improvement. Are you able to add these filters to the automated tests here https://github.com/joomla/joomla-cms/blob/4.3-dev/tests/Codeception/api/com_content/ContentCest.php? You can make new test functions for each filter.

avatar obuisard obuisard - change - 30 Nov 2022
Labels Added: PR-4.3-dev
Removed: ?
avatar obuisard obuisard - change - 1 Dec 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-12-01 12:29:25
Closed_By obuisard
avatar obuisard obuisard - close - 1 Dec 2022
avatar obuisard obuisard - merge - 1 Dec 2022
avatar obuisard
obuisard - comment - 1 Dec 2022

Thank you @antonbag for this great PR!
Would you be able to add the filters to the automated tests as @laoneo suggested a week ago or do you need help with that?

Add a Comment

Login with GitHub to post a comment