User tests: Successful: Unsuccessful:
Pull Request for Issue #38694
As mentiond here #38694 there is no transparent messaging from Joomla when you are running an site which does not meet the minimum requirements for example of the database.
I see here two solutions to this:
The latter is not b/c and if anything only something for majors to be changed.
In that case you can fake the tests mentiond here by doing the following:
Add the following two lines to this file: administrator\components\com_joomlaupdate\src\View\Joomlaupdate\HtmlView.php
at Line 179-180
$hasUpdate = true;
$hasDownload = false;
This will make sure you get the "no download URL found all the time".
The seccond check (new warning message) can be faked by reversing the check here after applying the patch: administrator\components\com_installer\src\Model\WarningsModel.php
at Line 180
from
if (Factory::getDbo()->isMinimumVersion() === false) {
to
if (Factory::getDbo()->isMinimumVersion() === true) {
No message at all.
The new page dedicated to this issue has to be created maybe under the "Help pages space"?: https://docs.joomla.org/Special:MyLanguage/J4.x:We_cant_find_a_download_url
@coolwebcreations Do you have a preference where to place such new doc page?
Said page should list the possible reasons for this message:
And also mention more deeper ways to check the points mentiond above. Like with the new warning within com_installer as well as that the update can be manually installed. But that should always be the last resort anyway.
By this we keep the message within the CMS as short as possibe but also have a dedicated place to document the issues and solutions.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer com_joomlaupdate Language & Strings |
Labels |
Added:
Language Change
Documentation Required
?
|
@coolcat-creations please click "check for Updates" thats not the message that is changed here.
I clicked on Check for Updates and thats the message (like in the screenshot) :-/
I have a client site with MySQL 5.1, I have the problem.
(However, I could not user patchtester because it is not installable on this hosting for mysql 5.1 (I guess), so I changed the files manually.)
Now my screens look like this:
For me it is correct, because there is an official Update for 4.2.7
and the warning is with valid information.
So, I think this is a confirmed test and expected behaviour, right?
So, I think this is a confirmed test and expected behaviour, right?
Yes please record it via the issue Tracker.
I have just updated the branch to make it ready to be merged by the release Leads :)
I have tested this item
This should go at the end into 4.3 and not 4.2 as it is a new feature.
This should go at the end into 4.3 and not 4.2 as it is a new feature.
It is by far nothing like a new feature and its awaiting progress since ages, its fixing a process flaw. My understading from @fancyFranci was that she is just awaiting tests here for this to be merged which we just got so this should be good to go into the next release which can also be 4.3 not sure from the top of my head whether we get another 4.2 release anyway :)
Yes, I'm finding testers for this because I want it in 4.2 :) The current message is misleading and kind of incorrect. The PR is fixing that problem.
Why do you want it in 4.2? What is so urgent? This is far more than a bug fix and should not come into a patch release.
Labels |
Added:
bug
PR-4.3-dev
Removed: ? |
Will close it here for now, looks like a none issue to people other than me.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-04 17:47:36 |
Closed_By | ⇒ | zero-24 |
This should not have been closed - just because one person didnt understand why this was so important - then it can be merged in 4.4 and users updating to j5 which has much stricter php and mysql requirements will not wonder why they cant see the updates.
There are always posts on the forum about users not seeing the updates
It is a useful improvement of the updater. Can you test this please @joeforjoomla ? :)