Language Change Documentation Required bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
21 Sep 2022

Pull Request for Issue #38694

Summary of Changes

As mentiond here #38694 there is no transparent messaging from Joomla when you are running an site which does not meet the minimum requirements for example of the database.

I see here two solutions to this:

  • improve the messaging within the CMS
  • had bail out of the CMS and show a message similiar to the PHP minimum version

The latter is not b/c and if anything only something for majors to be changed.

Testing Instructions

  • Setup a site that is running MySQL 5.5
  • Install Joomla 4.2.0
  • Note that an update to 4.2.2 or later will be shown
  • But no download URL will be found
  • Also check the installer warings (System -> Warnings)
  • Confirm that there is no warning showin by the core about that database version issue
  • apply this patch
  • Check the "We cant find an update" message again it will mention an (to be created once agreed here) doc page instead of a message which does not help to solve the issue.
  • Check the warnings tab and confirm there is a clear message showing the issue with the minimum database version.

When you dont have a mysql 5.5 or older setup

In that case you can fake the tests mentiond here by doing the following:

Add the following two lines to this file: administrator\components\com_joomlaupdate\src\View\Joomlaupdate\HtmlView.php at Line 179-180

        $hasUpdate = true;
        $hasDownload = false;

This will make sure you get the "no download URL found all the time".

The seccond check (new warning message) can be faked by reversing the check here after applying the patch: administrator\components\com_installer\src\Model\WarningsModel.php at Line 180

from

if (Factory::getDbo()->isMinimumVersion() === false) {

to

if (Factory::getDbo()->isMinimumVersion() === true) {

Actual result BEFORE applying this Pull Request

We cant find a download URL message

Screenshot 2022-09-21 140628

Warning within the com_installer warnings

No message at all.

Expected result AFTER applying this Pull Request

We cant find a download URL message

image

Warning within the com_installer warnings

image

Documentation Changes Required

The new page dedicated to this issue has to be created maybe under the "Help pages space"?: https://docs.joomla.org/Special:MyLanguage/J4.x:We_cant_find_a_download_url

@coolwebcreations Do you have a preference where to place such new doc page?

Said page should list the possible reasons for this message:

  • The update to Joomla %1$s is not available for your stability level (where to find and change that setting)
  • the update server setting (index.php?option=com_config&view=component&component=com_joomlaupdate) is not pointing to a official updateserver (where to find and change that setting)
  • this environment does not meet the minimum requirements (https://downloads.joomla.org/technical-requirements) for this update (where to find and change that setting)
  • there is a problem with the Joomla Update Server. (where to report issues with the update server)

And also mention more deeper ways to check the points mentiond above. Like with the new warning within com_installer as well as that the update can be manually installed. But that should always be the last resort anyway.

By this we keep the message within the CMS as short as possibe but also have a dedicated place to document the issues and solutions.

avatar zero-24 zero-24 - open - 21 Sep 2022
avatar zero-24 zero-24 - change - 21 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2022
Category Administration com_installer com_joomlaupdate Language & Strings
avatar zero-24 zero-24 - change - 21 Sep 2022
The description was changed
avatar zero-24 zero-24 - edited - 21 Sep 2022
avatar zero-24 zero-24 - change - 21 Sep 2022
Labels Added: Language Change Documentation Required ?
avatar fancyFranci
fancyFranci - comment - 22 Nov 2022

It is a useful improvement of the updater. Can you test this please @joeforjoomla ? :)

avatar coolcat-creations
coolcat-creations - comment - 19 Dec 2022

The Update Message does not seem to be quite right. It says that an update was found which is not possible I guess, because there is no update?
grafik

Edit: I installed the patch on a site with 10.5.18-MariaDB-1:10.5.18+maria~ubu2004-log and the message is still coming.

avatar zero-24
zero-24 - comment - 19 Dec 2022

@coolcat-creations please click "check for Updates" thats not the message that is changed here.

avatar coolcat-creations
coolcat-creations - comment - 20 Dec 2022

I clicked on Check for Updates and thats the message (like in the screenshot) :-/

avatar webgras
webgras - comment - 2 Feb 2023

I have a client site with MySQL 5.1, I have the problem.
(However, I could not user patchtester because it is not installable on this hosting for mysql 5.1 (I guess), so I changed the files manually.)
Now my screens look like this:
grafik
grafik

For me it is correct, because there is an official Update for 4.2.7
and the warning is with valid information.
So, I think this is a confirmed test and expected behaviour, right?

avatar zero-24
zero-24 - comment - 2 Feb 2023

So, I think this is a confirmed test and expected behaviour, right?

Yes please record it via the issue Tracker.

I have just updated the branch to make it ready to be merged by the release Leads :)

avatar webgras webgras - test_item - 2 Feb 2023 - Tested successfully
avatar webgras
webgras - comment - 2 Feb 2023

I have tested this item successfully on 71290ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38799.

avatar laoneo
laoneo - comment - 2 Feb 2023

This should go at the end into 4.3 and not 4.2 as it is a new feature.

avatar zero-24
zero-24 - comment - 2 Feb 2023

This should go at the end into 4.3 and not 4.2 as it is a new feature.

It is by far nothing like a new feature and its awaiting progress since ages, its fixing a process flaw. My understading from @fancyFranci was that she is just awaiting tests here for this to be merged which we just got so this should be good to go into the next release which can also be 4.3 not sure from the top of my head whether we get another 4.2 release anyway :)

avatar fancyFranci
fancyFranci - comment - 2 Feb 2023

Yes, I'm finding testers for this because I want it in 4.2 :) The current message is misleading and kind of incorrect. The PR is fixing that problem.

avatar laoneo
laoneo - comment - 3 Feb 2023

Why do you want it in 4.2? What is so urgent? This is far more than a bug fix and should not come into a patch release.

avatar zero-24 zero-24 - change - 18 Apr 2023
Labels Added: bug PR-4.3-dev
Removed: ?
avatar zero-24
zero-24 - comment - 4 Jun 2023

Will close it here for now, looks like a none issue to people other than me.

avatar zero-24 zero-24 - close - 4 Jun 2023
avatar zero-24 zero-24 - change - 4 Jun 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-06-04 17:47:36
Closed_By zero-24
avatar brianteeman
brianteeman - comment - 4 Oct 2023

This should not have been closed - just because one person didnt understand why this was so important - then it can be merged in 4.4 and users updating to j5 which has much stricter php and mysql requirements will not wonder why they cant see the updates.

There are always posts on the forum about users not seeing the updates

Add a Comment

Login with GitHub to post a comment