[#38797] - Allow to use filter.state for delete button in ListView
- Fixed in Code Base
- 22 Mar 2024
- Medium
- Build: 4.3-dev
- # 38797
- Diff
- HLeithner:feature/support_filter_state_for_trash_button
User tests: Successful: Unsuccessful:
Since Joomla! 4 we have a useful addToolBar function in ListView which generates the toolbar pretty well. But it's missing to accept the filter.state instead of the legacy filter.published used in some components. Since Joomla ist self also uses filter.state it should support it here too.
Summary of Changes
Check current value of the state filter.state and filter.published.
I would not expect any b/c issues because both values are used for the same usecase and at the moment you have to override addToolbar anyway to use the filter.state.
Testing Instructions
Test core joomla extensions if filtering for the status "Trashed" still work.
Bonus create an extension which users filter.state as column field. (of course I tested it and it's working)
Actual result BEFORE applying this Pull Request
- Trash button still Trash button
Expected result AFTER applying this Pull Request
- Trash button is now a Delete button
Documentation Changes Required
Not really because base documentation is missing.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-4.3-dev
|
||
@richard67 pr was not uptodate with 4.3-dev branch and the openldap service was missing.
This pull request has been automatically rebased to 4.4-dev.
| Labels |
Added:
bug
Small
PR-4.4-dev
Removed: PR-4.3-dev |
||
I spent some time trying to test this, but I could not confirm this works.
I am not sure I correctly understand how to test this.
Can you please add more detailed instructions how to test this?
@tomsrocket This class is actually not used in Joomla core, so it would be for someone with code review skill. So unless you have developer experience, please ignore this PR.
I have tested this item ✅ successfully on 628d53a
Code review !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797.
I have tested this item ✅ successfully on 628d53a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38797.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-22 12:03:01 |
| Closed_By | ⇒ | laoneo |
Thanks!
Unit tests are consistently failing here, but I think it’s not related to this PR. The LDAP authentication tests are failing. Could be a problem on the 4.3-dev branch in general.