Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#38796] - [4.2] Do not checkout a record when the user is not logged in

? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 Sep 2022

Summary of Changes

When not logged in users can create articles, an exception is thrown that the article can not be checked out when saving it.

Testing Instructions

  • Set the create permission for the public user group to allowed.
  • Create a "Create Article" menu item
  • Open the front end as not logged in user
  • Go to the "Create Article" menu item
  • Set a title in the form
  • Click on the "Save" button (NOT "Save and Close")

Actual result BEFORE applying this Pull Request

"Argument 'userId' of event onTableBeforeCheckout must be an integer " error is displayed.

Expected result AFTER applying this Pull Request

FrontPage is loaded with text "Article submitted.".

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00
avatar laoneo laoneo - open - 21 Sep 2022
avatar laoneo laoneo - change - 21 Sep 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2022
Category ⇒ Libraries
avatar laoneo laoneo - change - 21 Sep 2022
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2022
Category Libraries ⇒ Libraries Unit Tests
avatar conseilgouz
conseilgouz - comment - 14 Oct 2022

Hi,

Any news about this PR ? it's marked "blocked"

avatar alikon
alikon - comment - 14 Oct 2022

as usual it needs test

avatar HDInfautre
HDInfautre - comment - 14 Oct 2022

Hello
I have successfully tested this patch with patch tester

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

avatar conseilgouz
conseilgouz - comment - 14 Oct 2022

I have tested this item ✅ successfully on 7c4fe6b

Joomla 4.2.3, PHP 8.1.5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

avatar conseilgouz conseilgouz - test_item - 14 Oct 2022 - Tested successfully
avatar HDInfautre
HDInfautre - comment - 14 Oct 2022

I have tested this item ✅ successfully on 7c4fe6b

Hello
I have successfully tested this patch with patch tester (joomla 4.2.3)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

avatar HDInfautre HDInfautre - test_item - 14 Oct 2022 - Tested successfully
avatar alikon alikon - change - 14 Oct 2022
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 14 Oct 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38796.

avatar HLeithner HLeithner - change - 15 Oct 2022
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-10-15 08:40:51
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 15 Oct 2022
avatar HLeithner HLeithner - merge - 15 Oct 2022
avatar HLeithner
HLeithner - comment - 15 Oct 2022

Thanks

Add a Comment

Login with GitHub to post a comment