? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Aug 2022

Summary of Changes

If the time format is 12hr then the am/pm dropdown is not large enough

Testing Instructions

  1. Apply the PR and rebuild the js or use a prebuilt package
  2. change any date field to add timeformat="12" in the xml

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar brianteeman brianteeman - open - 23 Aug 2022
avatar brianteeman brianteeman - change - 23 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2022
Category JavaScript Repository NPM Change
avatar RickR2H
RickR2H - comment - 23 Aug 2022

I have tested this item successfully on 3b012d4

I used mod_articles_category.xml to test. I added timeformat="12" the start_date_range field. The am/pm is now visible!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38562.

avatar RickR2H RickR2H - test_item - 23 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 23 Aug 2022

I have tested this item successfully on 3b012d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38562.

avatar viocassel viocassel - test_item - 23 Aug 2022 - Tested successfully
avatar RickR2H RickR2H - change - 23 Aug 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 23 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38562.

avatar wilsonge wilsonge - change - 6 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-06 10:28:53
Closed_By wilsonge
Labels Added: ? NPM Resource Changed ?
avatar wilsonge wilsonge - close - 6 Sep 2022
avatar wilsonge wilsonge - merge - 6 Sep 2022
avatar wilsonge
wilsonge - comment - 6 Sep 2022

Thanks!

avatar brianteeman
brianteeman - comment - 6 Sep 2022

thanks

Add a Comment

Login with GitHub to post a comment