? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Aug 2022

Pull Request for #20556 and multiple closed issues

Create menu consisting of URL type items and subitems of any type(that is important)
Go to Modules -> New -> Menu
Try to select as Base item the URL type items you added

url, alias, heading etc were not selectable. The logic made sense as you can't click on one of those to open a submenu. However as you can open a submenu by hover then it does have a purpose so this PR removes that restriction

avatar brianteeman brianteeman - open - 23 Aug 2022
avatar brianteeman brianteeman - change - 23 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2022
Category Administration com_menus
avatar RickR2H
RickR2H - comment - 23 Aug 2022

I have tested this item successfully on cbdf9f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563.

avatar RickR2H RickR2H - test_item - 23 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 23 Aug 2022

I have tested this item successfully on cbdf9f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563.

avatar viocassel viocassel - test_item - 23 Aug 2022 - Tested successfully
avatar alikon alikon - change - 23 Aug 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38563.

avatar fancyFranci
fancyFranci - comment - 15 Sep 2022

Sorry, but to be sure we are not missing something I'm moving the PR to 4.3. Then we have more tests. Thanks for your work!

avatar brianteeman
brianteeman - comment - 15 Sep 2022

Very sad face

avatar viocassel
viocassel - comment - 16 Sep 2022

?

avatar obuisard obuisard - change - 17 Sep 2022
Labels Added: ? PR-4.3-dev
avatar obuisard obuisard - change - 17 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-17 17:51:22
Closed_By obuisard
avatar obuisard obuisard - close - 17 Sep 2022
avatar obuisard obuisard - merge - 17 Sep 2022
avatar obuisard
obuisard - comment - 17 Sep 2022

Thank you Brian @brianteeman for the PR.

Add a Comment

Login with GitHub to post a comment