[#3825] - Dynamic JConfig
- Closed
- 25 Jun 2014
- Medium
- Build: master
- # 3825
I have a Joomla repository on git, obviously I do not want to commit database credentials, plus it means that every time I deploy the repository somewhere I don't have to install.
I know people might say "but what about the installation" I have a deployment script which handles it. However this is the part of which I am stuck on.
Here is what I have as my configuration.php
https://gist.github.com/bweston92/4de89b7f22b5cde1647c
Unfortunately it gets converted into a JRegistry object which kills the purpose and creates an empty JRegistry object.
Proposed solution, ok so for people who want to use this feature are able to have a JConfig class that extends JRegistry, then when the factory comes to loading the configuration it can see check JConfig class extends JRegistry. We could however make a interface like ConfigurationInterface that if JConfig doesn't implement then it will revert to loading the class into a JRegistry object.
Say I deploy to Fortrabbit and then I set the enviromental variables I can deploy all day long without having to worry about the installation process. (Installation CLI I have created run the SQL from the installation folder)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-25 17:39:51 |
zero-24
- 
Ok, but correct me if I'm wrong it is an issue. The proposed solutions could be spoken about and then I or someone else can implement them and create a PR and relate it to this issue.—
Sent from Mailbox for iPhone
On Wed, Jun 25, 2014 at 6:39 PM, Thomas Hunziker notifications@github.com
wrote:
I'm not sure what the purpose of this issue here is. It doesn't looks like an actual issue with the CMS.
As issues aren't really meant to discuss possible new features or finding user solution, may I ask you to discuss this in the CMS Development Google group: https://groups.google.com/forum/#!forum/joomla-dev-cms or the General Development Google group: https://groups.google.com/forum/#!forum/joomla-dev-general.Thanks.
Reply to this email directly or view it on GitHub:
#3825 (comment)
A PR would create a new issue anyways.
Discussing various solutions should be done in the CMS Google Group I linked earlier. That's why we have that one. GitHub is not an ideal place to have such discussions.
It's great once we have a PR to discuss that proposed code.
| Labels |
Added:
?
|
||
I'm not sure what the purpose of this issue here is. It doesn't looks like an actual issue with the CMS.
As issues aren't really meant to discuss possible new features or finding user solution, may I ask you to discuss this in the CMS Development Google group: https://groups.google.com/forum/#!forum/joomla-dev-cms or the General Development Google group: https://groups.google.com/forum/#!forum/joomla-dev-general.
Thanks.