[#3826] - Bug Fix in module helper
- Closed - Unconfirmed Report
- 17 Oct 2014
- Medium
- Build: master
- # 3826
Steps to reproduce the issue
Enable show warnings in php
Give warnings in libraries/joomla/application/module/helper.php
Expected result
No warnings
Actual result
Warning on line 200 e line 209
System information (as much as possible)
Joomla 2.5.22
PHP 5.5.9
Cent OS 6
Correction
Put this code in line 197.
if (is_string($attribs)) {
$t = explode(',', $attribs);
$attribs = array();
foreach ($t as $a) {
if (!empty($a)) {
$b = explode('=', $a);
$attribs[$b[0]] = $b[1];
}
}
}
You havent made a Pull Request against Joomla - just your own fork. ;)
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
Hi @prma85 ,
When you click the Pull icon, make sure you change the base repo to be joomla/joomla-cms , as in this screenshot:
http://docs.joomla.org/File:Easygithub7.png
| Labels |
Added:
?
|
||
This issue is no longer represented in the code. The lines numbers mentioned in the original issue does not correspond with the proposed fix. And as far as I could tell, nothing in that file should give any notices, so I think we can close this issue.
@aDaneInSpain just confirming before I close this that you were checking against 2.5
Yes, I was.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3826.
Thanks for confirming that @adaneinspain
I am going to close this for now as an uncomfirmed report as it is against an old release of 2.5 it can always be reopened if further information etc is provided.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3826.
Set to "closed" on behalf of @brianteeman by The JTracker Application at issues.joomla.org/joomla-cms/3826
zero-24
- 
| Status | Pending | ⇒ | Closed - Unconfirmed Report |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-17 10:41:56 |
| Labels |
Added:
?
|
||
Since you already propose a solution, can you please do a Pull Request?
It's simpler than it sounds. Have a look at http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests for how to use the GitHub UI to do that.
That would be really helpful.