? Success

User tests: Successful: Unsuccessful:

avatar Hils
Hils
24 Jun 2014

To make the error message more helpful/user friendly when user tries to delete a template in the Template Manager rather than the Extension Manager.

To test: Try to delete a non-default template using the delete button in the Template Manager. You should now receive instructions how it should be done!

avatar Hils Hils - open - 24 Jun 2014
avatar brianteeman
brianteeman - comment - 24 Jun 2014

@Hils I 100% get what you are trying to do here. However I think that its also correct to tell people that they cant delete the last style of a template. I can see a scenario where a user thinks they can remove all styles without removing the template.

How about a compromise of combining the existing string with your new string.

avatar betweenbrain
betweenbrain - comment - 24 Jun 2014

How about a compromise of combining the existing string with your new string.
+1

avatar Hils
Hils - comment - 25 Jun 2014

@brianteeman @betweenbrain Thank you for looking at this - much appreciated.

"Cannot delete last style of a template" - if you think this should be there as well, fine, but the reason I first did this PR is because I don't understand what it means. What is the last style of a template please? Styling in templates, for me, means CSS!

So there are three choices - I will be guided by you which one I should use:
1. Extensions > (space before >)
2. Extensions-> (no space)
3. Extensions -> (space before)

Thanks again from Hils

avatar brianteeman
brianteeman - comment - 25 Jun 2014

a style refers to a saved set of options for a template and every template must have one - hence the error message. But I agree that in most cases someone would be deleting a style thinking that is what they should do to delete a template hence my suggestion to combine the two messages.

j and beyond 2014 administration template manager styles

As we only have one existing case then for now I would stick with that and use
2. Extensions-> (no space)

avatar infograf768
infograf768 - comment - 25 Jun 2014

Agree we should combine

avatar brianteeman
brianteeman - comment - 25 Jun 2014

All good to go from me - thanks @Hils

avatar Hils
Hils - comment - 25 Jun 2014

Thanks for all the input. All changes made :)

avatar betweenbrain
betweenbrain - comment - 25 Jun 2014

Looks good to me too. Thanks @Hils!

avatar Bakual Bakual - close - 9 Jul 2014
avatar Bakual Bakual - change - 9 Jul 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-07-09 19:58:09
avatar Bakual Bakual - close - 9 Jul 2014
avatar Hils Hils - head_ref_deleted - 9 Jul 2014
avatar zero-24 zero-24 - reference | - 10 Jul 14

Add a Comment

Login with GitHub to post a comment