[#38242] - Add space before pgeclass-sfx
- Closed
- 7 Jul 2022
- Medium
- Build: 4.2-dev
- # 38242
- Diff
- chmst:blog-item-page-break
User tests: Successful: Unsuccessful:
Pull Request for Issue #38238 .
Summary of Changes
As title says - seems that this was forgotten.
Testing Instructions
Add a page class to menu item for a single article.
class="com-content-article item-page my-class
Actual result BEFORE applying this Pull Request
class="com-content-article item-pagemyclass
Expected result AFTER applying this Pull Request
class="com-content-article item-page myclass
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
We could make it ugly like this class="com-content-article item-pagemyclass myclass
But as it is now, we use this pageclass_sfx in an inconsistent way. I have already made an extra override in a site for that.
@brianteeman your opinion? It is ugly - no matter what we do here ;)
The ugly option obviously won't work
To be clear I don't have a problem with adding a space. It's just my memory saying it wasn't forgotten and there was a reason.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-07 10:32:30 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
lol - so much for my memory
pretty sure that this one was kept for b/c - there will be a discussion on it somewhere in one of the many template repositories