? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Jul 2022

Summary of Changes

adds a custom field to show a list of all menu items that can be selected and then displayed as a link in the frontend

Testing Instructions

Install a prebuilt package
or
Install this PR, discover the extension and publish the plugin

Create a menuitem custom field. Check that it shows all menuitems from all menus in the select ;ist and then check on the front end that the link is displayed.

Expected result AFTER applying this Pull Request

image

image

image

Documentation Changes Required

New plugin

avatar brianteeman brianteeman - open - 7 Jul 2022
avatar brianteeman brianteeman - change - 7 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jul 2022
Category SQL Administration com_admin Postgresql Language & Strings Installation Libraries Front End Plugins
avatar brianteeman brianteeman - change - 7 Jul 2022
Labels Added: Language Change ?
avatar woluweb woluweb - test_item - 8 Jul 2022 - Tested successfully
avatar woluweb
woluweb - comment - 8 Jul 2022

I have tested this item successfully on b304e06

Hi,

Txs very much Brian for introducing this new Type of Custom Fields!

Note for those who don't know: this follows a question I raised yesterday on the Joomla Facebook Group: https://www.facebook.com/groups/joomlanospam/posts/10158401801610997/

I have tested this successfully (on an existing J4.1 website).
You can see the result on https://subform.joomlacustomfields.org/ (link "Matrioshka" at the bottom of Article 1).

This new Type of Custom Fields can be useful in many cases.
But let me share here my own usecase as it could give ideas to others: suppose you have a Blog View... but when clicking on one of the post you don't want to open the corresponding article... but another Blog View. With other words, you want "nested Blog Views" (ie a kind of "Matryoshka").

Txs again Brian for this (very) quick PR :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38244.

avatar viocassel viocassel - test_item - 8 Jul 2022 - Tested successfully
avatar viocassel
viocassel - comment - 8 Jul 2022

I have tested this item successfully on b304e06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38244.

avatar richard67 richard67 - change - 8 Jul 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 8 Jul 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38244.

avatar roland-d roland-d - change - 13 Jul 2022
Labels Added: ?
avatar roland-d roland-d - change - 13 Jul 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-07-13 17:40:42
Closed_By roland-d
avatar roland-d roland-d - close - 13 Jul 2022
avatar roland-d roland-d - merge - 13 Jul 2022
avatar roland-d
roland-d - comment - 13 Jul 2022

Thank you.

avatar HLeithner
HLeithner - comment - 8 Aug 2022

@chmst found out that this field breaks if you set a default value
image

avatar roland-d
roland-d - comment - 8 Aug 2022

So I checked and the Default value has no use in this field. However there is no toggle we can set to not show it for a specific field. Due to being there and when filled, it is added as XML element to the list of options to render and this crashes because it is not used and as such does not match anything and the default is throw this error message.

Since the default makes no sense here, I will create a PR where the field itself can decide if the Default value should be shown.

avatar roland-d
roland-d - comment - 8 Aug 2022

PR created: #38423

avatar roland-d
roland-d - comment - 14 Aug 2022

This PR has unfortunately been reverted as there are more issues to be resolved. Related PRs with fixes are:

It is best to roll this PR and the other PRs into 1 new PR for 4.3, so we have more time to test and verify the solutions.

avatar brianteeman
brianteeman - comment - 14 Aug 2022

only because we both misread each others comments

avatar laoneo
laoneo - comment - 14 Aug 2022

Best thing would be to offer the plugin in the JED and not bloat the core.

avatar brianteeman
brianteeman - comment - 14 Aug 2022

Why? Then we should remove all the plugins that are for core fields. Honestly that makes zero sense.

avatar laoneo
laoneo - comment - 15 Aug 2022

Because core has already over 200 extensions when you do a blank installation, which I think is more than enough. Instead of, we should try to push the extension directory.

Add a Comment

Login with GitHub to post a comment